Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed Styling issues on Login Page #2974

Merged
merged 7 commits into from
Aug 2, 2022
Merged

Fixed Styling issues on Login Page #2974

merged 7 commits into from
Aug 2, 2022

Conversation

aeswibon
Copy link
Member

@aeswibon aeswibon commented Jul 2, 2022

Updates

@aeswibon aeswibon requested a review from a team July 2, 2022 14:08
@aeswibon aeswibon requested a review from a team as a code owner July 2, 2022 14:08
rithviknishad
rithviknishad requested changes Jul 3, 2022
View reviewed changes
Copy link
Member

@rithviknishad rithviknishad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@cp-coder how about using the pointer cursor instead of the default one for the language selector.
image

@aeswibon
Copy link
Member Author

aeswibon commented Jul 3, 2022

@rithviknishad I have now added the pointer cursor on the Language selector

@aeswibon
Copy link
Member Author

aeswibon commented Jul 3, 2022

@nihal467 This PR is good for testing

@nihal467
Copy link
Member

nihal467 commented Jul 3, 2022

18

@cp-coder the forget password button is misaligned, make it aligned to login button

naman114
naman114 approved these changes Jul 4, 2022
View reviewed changes
Copy link
Contributor

@naman114 naman114 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nihal467
Copy link
Member

nihal467 commented Jul 6, 2022 •
edited
Loading

34

@cp-coder the spacing between forgot button and password is having more space, can you reduce it and make everything uniformly spaced !

@nihal467
Copy link
Member

@cp-coder status of the PR

@aeswibon
Copy link
Member Author

@nihal467 Is this okay??
image

@nihal467
Copy link
Member

@cp-coder

image

make it responsive

@nihal467
Copy link
Member

@cp-coder what is the status

@netlify
Copy link

netlify bot commented Jul 28, 2022 •
edited
Loading

✅ Deploy Preview for care-egov-staging ready!

Name Link
🔨 Latest commit 06087f3
🔍 Latest deploy log https://app.netlify.com/sites/care-egov-staging/deploys/62e2b276f65a6a0008605cd9
😎 Deploy Preview https://deploy-preview-2974--care-egov-staging.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@aeswibon
Copy link
Member Author

@nihal467 Updated view:
image

@sonarcloud
Copy link

sonarcloud bot commented Jul 28, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 1 Code Smell

No Coverage information No Coverage information
0.0% 0.0% Duplication

@nihal467
Copy link
Member

test approved

@khavinshankar khavinshankar merged commit 885bd4f into ohcnetwork:develop Aug 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kunatastic kunatastic kunatastic left review comments

@naman114 naman114 naman114 approved these changes

@khavinshankar khavinshankar khavinshankar approved these changes

@rithviknishad rithviknishad rithviknishad approved these changes

Assignees
No one assigned
Labels
peer-reviewed tested
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Login Page : Alignment and Border Issues
6 participants
@aeswibon @nihal467 @rithviknishad @khavinshankar @naman114 @kunatastic