Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added username validator #3023

Merged
merged 6 commits into from
Jul 21, 2022
Merged

Added username validator #3023

merged 6 commits into from
Jul 21, 2022

Conversation

shivankacker
Copy link
Member

closes #2891

@shivankacker shivankacker requested a review from a team July 6, 2022 13:38
@shivankacker shivankacker requested a review from a team as a code owner July 6, 2022 13:38
GokulramGHV
GokulramGHV reviewed Jul 10, 2022
View reviewed changes
Copy link
Member

@GokulramGHV GokulramGHV left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@skks1212 It shows 'Available' even if the user already exists. But it seems to work with the username that's currently logged in..
image
image

image
image

@shivankacker
Copy link
Member Author

@GokulramGHV I see! Thanks for pointing this out, il fix it asap

@nihal467
Copy link
Member

@skks1212
8

  • since, it is breaking the rules, the user name shouldn't be marked as available
  • cab we have this available displayed as the conditions are displayed

@nihal467
Copy link
Member

10

@skks1212 unable to create a user

@nihal467
Copy link
Member

11

@skks1212 test failed

@shivankacker
Copy link
Member Author

@nihal467 did you try hard refreshing? I just created an account with that username

@nihal467
Copy link
Member

test approved

khavinshankar
khavinshankar requested changes Jul 12, 2022
View reviewed changes
src/Components/Users/UserAdd.tsx Show resolved Hide resolved
src/Components/Users/UserAdd.tsx Show resolved Hide resolved
@khavinshankar khavinshankar merged commit da40a71 into ohcnetwork:develop Jul 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@GokulramGHV GokulramGHV GokulramGHV left review comments

@khavinshankar khavinshankar khavinshankar approved these changes

Assignees
No one assigned
Labels
tested
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add user name validator : User Creation
4 participants
@shivankacker @nihal467 @khavinshankar @GokulramGHV