Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Help Button in User create page #3109

Merged
merged 6 commits into from
Aug 25, 2022
Merged

Fix Help Button in User create page #3109

merged 6 commits into from
Aug 25, 2022

Conversation

shivankacker
Copy link
Member

@shivankacker shivankacker commented Jul 11, 2022 •
edited
Loading

closes #3107
image

@shivankacker shivankacker marked this pull request as ready for review July 15, 2022 18:03
@shivankacker shivankacker requested a review from a team July 15, 2022 18:03
@shivankacker shivankacker requested a review from a team as a code owner July 15, 2022 18:03
@netlify
Copy link

netlify bot commented Jul 15, 2022 •
edited
Loading

✅ Deploy Preview for care-egov-staging ready!

Name Link
🔨 Latest commit 1ab5b98
🔍 Latest deploy log https://app.netlify.com/sites/care-egov-staging/deploys/630500bd5c2f3b0008997125
😎 Deploy Preview https://deploy-preview-3109--care-egov-staging.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@sonarcloud
Copy link

sonarcloud bot commented Jul 15, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 1 Code Smell

No Coverage information No Coverage information
0.8% 0.8% Duplication

@nihal467
Copy link
Member

@skks1212
image

having this much space covered with need help doesn't give a good look, can we have an alternative design

@nihal467
Copy link
Member

@skks1212
image

  • change the button to the right side of the same line where the add user is located
  • change the colour from violet to grey

@shivankacker
Copy link
Member Author

@nihal467 I have changed the button position, but gray color was looking a bit dull and seemed like the button was disabled.
image

Thus i changed the color to green.
image

@nihal467
Copy link
Member

@skks1212 can you ask @gigincg or post in slack

@shivankacker
Copy link
Member Author

image
@nihal467 I had a talk with Gigin, he has suggested to keep it gray

@sonarcloud
Copy link

sonarcloud bot commented Aug 23, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 4 Code Smells

No Coverage information No Coverage information
0.5% 0.5% Duplication

@nihal467
Copy link
Member

test approved

@khavinshankar khavinshankar merged commit a817d56 into ohcnetwork:develop Aug 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@khavinshankar khavinshankar khavinshankar approved these changes

@SandeepThomas SandeepThomas Awaiting requested review from SandeepThomas

Assignees
No one assigned
Labels
tested
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Redesign need help button
3 participants
@shivankacker @nihal467 @khavinshankar