Added icons to Asset page and enhanced the UI #3117
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
❌ Deploy Preview for care-net failed.
|
kunatastic
suggested changes
Jul 14, 2022
|
Hey, @kunatastic I have moved the SVG icons to a component so they can be reused. |
kunatastic
approved these changes
Jul 14, 2022
developedBySJ
suggested changes
Jul 14, 2022
|
@developedBySJ I have fixed all the type issues as suggested I have added a solid variant icon |
|
tested |
|
@nihal467 @patelaryan7751 is this pr complete? Aren't you making this icons as pictures, right? |
|
@patelaryan7751 @khavinshankar I think, rather than an icon, we have to make it a picture, that is what we have discussed in the EOD call as far as I remember. Aryan, shall we discuss it in the EOD call ! |
patelaryan7751
force-pushed
the
issue#3116
branch
from
79f7652
to
36e2e8a
Compare
✅ Deploy Preview for care-egov-staging ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
|
Kudos, SonarCloud Quality Gate passed!
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3116
Enhancement
Added icons to Asset page and enhanced the UI