Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: last-seen overflow #3205

Closed
wants to merge 3 commits into from
Closed

fix: last-seen overflow #3205

wants to merge 3 commits into from

Conversation

kunatastic
Copy link
Contributor

closes #3038

image

@kunatastic kunatastic requested a review from a team July 23, 2022 12:14
@kunatastic kunatastic requested a review from a team as a code owner July 23, 2022 12:14
@netlify
Copy link

netlify bot commented Jul 23, 2022 •
edited
Loading

✅ Deploy Preview for care-egov-staging ready!

Name Link
🔨 Latest commit 72e4a4e
🔍 Latest deploy log https://app.netlify.com/sites/care-egov-staging/deploys/62ecef56f5980200083e1f38
😎 Deploy Preview https://deploy-preview-3205--care-egov-staging.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@nihal467
Copy link
Member

@kunatastic @developedBySJ once its completed change the status to need testing

@nihal467
Copy link
Member

test approved

@khavinshankar khavinshankar added good to merge merge conflict pull requests with merge conflict and removed good to merge labels Jul 28, 2022
@kunatastic kunatastic removed the merge conflict pull requests with merge conflict label Aug 5, 2022
@sonarcloud
Copy link

sonarcloud bot commented Aug 5, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@khavinshankar
Copy link
Member

@developedBySJ can you please rereview this?

@gigincg
Copy link
Member

gigincg commented Aug 11, 2022

@nihal467 This looks super weird in Desktop View. Why is this approved.

image

@kunatastic Use flex-wrap so that it goes over only when there isn't enough space

@stale
Copy link

stale bot commented Oct 8, 2022

Hi, @${author}, This pr/issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs for 7 more days. Thank you for your contributions.

@stale stale bot added the stale label Oct 8, 2022
@stale
Copy link

stale bot commented Oct 15, 2022

Hi, @gigincg, @nihal467, @khavinshankar, @mathew-alex This pr/issue has been automatically closed because it has not had any recent activity. Thank you for your contributions. Feel free to repopen the pr/issue.

@stale stale bot closed this Oct 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@developedBySJ developedBySJ developedBySJ requested changes

@aeswibon aeswibon aeswibon approved these changes

@khavinshankar khavinshankar khavinshankar approved these changes

@Ashesh3 Ashesh3 Ashesh3 approved these changes

@vigneshhari vigneshhari Awaiting requested review from vigneshhari

Assignees
No one assigned
Labels
changes required stale test failed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

User last seen overflow
7 participants
@kunatastic @nihal467 @khavinshankar @gigincg @Ashesh3 @developedBySJ @aeswibon