Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: remove raw css file import from .res files in critical care recording #3307

Merged
merged 3 commits into from
Feb 8, 2023
Merged

fix: remove raw css file import from .res files in critical care recording #3307

merged 3 commits into from
Feb 8, 2023

Conversation

Pragati1610
Copy link
Contributor

@Pragati1610 Pragati1610 commented Aug 3, 2022 •
edited
Loading

fixes: #3292

@Pragati1610 Pragati1610 requested a review from a team August 3, 2022 15:02
@Pragati1610 Pragati1610 requested a review from a team as a code owner August 3, 2022 15:02
@sonarcloud
Copy link

sonarcloud bot commented Aug 3, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 2 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@netlify
Copy link

netlify bot commented Aug 3, 2022 •
edited
Loading

✅ Deploy Preview for care-egov-staging ready!

Name Link
🔨 Latest commit 446a755
🔍 Latest deploy log https://app.netlify.com/sites/care-egov-staging/deploys/63e34207d655300008a425ca
😎 Deploy Preview https://deploy-preview-3307--care-egov-staging.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@nihal467
Copy link
Member

@khavinshankar can you check this

@nihal467 nihal467 requested review from khavinshankar and removed request for SandeepThomas August 23, 2022 05:45
@nihal467
Copy link
Member

@Pragati1610 can you check the merge conflict

@khavinshankar khavinshankar added merge conflict pull requests with merge conflict and removed Done good to merge labels Sep 26, 2022
@khavinshankar
Copy link
Member

@Pragati1610 can you please resolve the merge conflict and if that involves ui changes do use need testing label

@netlify
Copy link

netlify bot commented Oct 3, 2022 •
edited
Loading

❌ Deploy Preview for care-net failed.

Name Link
🔨 Latest commit a02e052
🔍 Latest deploy log https://app.netlify.com/sites/care-net/deploys/63d8de07c9b5fe0009c7319d

@github-actions github-actions bot removed the merge conflict pull requests with merge conflict label Oct 3, 2022
@stale
Copy link

stale bot commented Oct 12, 2022

Hi, This pr/issue has been automatically marked as stale because it has not had any recent activity. It will be closed if no further activity occurs for 7 more days. Thank you for your contributions.

@stale stale bot added the stale label Oct 12, 2022
@github-actions github-actions bot added the merge conflict pull requests with merge conflict label Oct 14, 2022
@github-actions
Copy link

👋 Hi, @Pragati1610,
Conflicts have been detected against the base branch. Please rebase your branch against the base branch.

This message is automatically generated by prince-chrismc/label-merge-conflicts-action so don't hesitate to report issues/improvements there.

1 similar comment
@github-actions
Copy link

👋 Hi, @Pragati1610,
Conflicts have been detected against the base branch. Please rebase your branch against the base branch.

This message is automatically generated by prince-chrismc/label-merge-conflicts-action so don't hesitate to report issues/improvements there.

@Pragati1610 Pragati1610 removed the merge conflict pull requests with merge conflict label Oct 20, 2022
@github-actions github-actions bot added the merge conflict pull requests with merge conflict label Dec 22, 2022
@github-actions
Copy link

👋 Hi, @Pragati1610,
Conflicts have been detected against the base branch. Please rebase your branch against the base branch.

This message is automatically generated by prince-chrismc/label-merge-conflicts-action so don't hesitate to report issues/improvements there.

@nihal467
Copy link
Member

nihal467 commented Jan 9, 2023

@khavinshankar can you follow up on this PR

@nihal467 nihal467 added the waiting for update PR is been dead for a long time label Jan 9, 2023
@Pragati1610
Copy link
Contributor Author

resolving the conflicts

@github-actions github-actions bot added Deploy-Failed Deplyment is not showing preview and removed merge conflict pull requests with merge conflict labels Jan 31, 2023
@nihal467
Copy link
Member

nihal467 commented Feb 3, 2023

@Pragati1610 what is the status on the PR

@nihal467 nihal467 removed the waiting for update PR is been dead for a long time label Feb 6, 2023
@nihal467
Copy link
Member

nihal467 commented Feb 6, 2023

@Pragati1610 clear the changes and try to get it merged this week itself

cc: @khavinshankar

@sonarcloud
Copy link

sonarcloud bot commented Feb 8, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 4 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@Pragati1610 Pragati1610 added needs review needs testing and removed Deploy-Failed Deplyment is not showing preview stale labels Feb 8, 2023
@khavinshankar
Copy link
Member

putting it on hold as this is just a refactor

@khavinshankar khavinshankar merged commit 9164064 into ohcnetwork:develop Feb 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rithviknishad rithviknishad rithviknishad left review comments

@khavinshankar khavinshankar khavinshankar approved these changes

Assignees
No one assigned
Labels
changes required hold
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Remove Raw Css file import from .res files in critical care recording
4 participants
@Pragati1610 @nihal467 @khavinshankar @rithviknishad