Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Minor Improvement of UI of medicine tab in patient dashboard page #3408

Merged
merged 5 commits into from
Sep 8, 2022
Merged

Minor Improvement of UI of medicine tab in patient dashboard page #3408

merged 5 commits into from
Sep 8, 2022

Conversation

patelaryan7751
Copy link
Contributor

@patelaryan7751 patelaryan7751 commented Aug 15, 2022 •
edited
Loading

Proposed Changes

Fixes #3384

  • The Prescription Time should come down the next line below the Prescription Heading
  • Horizontal padding should be added in the box containing the message "No Consultation Updates Found" in Consultation Updates section
    image

@coronasafe/reviewers

Merge Checklist

  • Add specs that demonstrate bug / test a new feature.
  • Update product documentation.
  • Ensure that UI text is kept in I18n files.
  • Prep screenshot or demo video for changelog entry, and attach it to issue.
  • Request for Peer Reviews
  • Completion of QA

@patelaryan7751 patelaryan7751 requested a review from a team August 15, 2022 10:14
@patelaryan7751 patelaryan7751 requested a review from a team as a code owner August 15, 2022 10:14
@netlify
Copy link

netlify bot commented Aug 15, 2022 •
edited
Loading

✅ Deploy Preview for care-egov-staging ready!

Name Link
🔨 Latest commit fd88581
🔍 Latest deploy log https://app.netlify.com/sites/care-egov-staging/deploys/63169b80f6e2150008e221e3
😎 Deploy Preview https://deploy-preview-3408--care-egov-staging.netlify.app/
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@nihal467
Copy link
Member

@patelaryan7751 once the work is completed, change it to need testing

@nihal467
Copy link
Member

@patelaryan7751
image

moving the time from left to right in the normal view was intentional or not ! as currently staging it is on the left near the prescription heading !

@nihal467 nihal467 added the question Further information is requested label Aug 24, 2022
@patelaryan7751
Copy link
Contributor Author

patelaryan7751 commented Aug 30, 2022 •
edited
Loading

@nihal467 It was not intentional i have fixed the bug
image

Now the page would look like this in samsung fold

image

@patelaryan7751 patelaryan7751 removed the question Further information is requested label Aug 30, 2022
@nihal467
Copy link
Member

test approved

@khavinshankar
Copy link
Member

@developedBySJ can you rereview this one?

@nihal467 nihal467 added Cypress Test Pending The Cypress test are to be verified and removed tested labels Sep 5, 2022
@nihal467
Copy link
Member

nihal467 commented Sep 5, 2022

@patelaryan7751 merge the latest development branch and check the cypress test is passing or not,

@nihal467 nihal467 added the tested label Sep 5, 2022
@sonarcloud
Copy link

sonarcloud bot commented Sep 6, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@gigincg gigincg merged commit 02bda57 into ohcnetwork:develop Sep 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aeswibon aeswibon aeswibon approved these changes

@khavinshankar khavinshankar khavinshankar approved these changes

@gigincg gigincg gigincg approved these changes

@bodhish bodhish Awaiting requested review from bodhish

@developedBySJ developedBySJ Awaiting requested review from developedBySJ

Assignees
No one assigned
Labels
Cypress Test Pending The Cypress test are to be verified tested
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Minor Improvement of UI of medicine tab in patient dashboard page.
6 participants
@patelaryan7751 @nihal467 @khavinshankar @gigincg @developedBySJ @aeswibon