-
Notifications
You must be signed in to change notification settings - Fork 437
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adds fields to Asset model as per asset registration v2 #3458
Adds fields to Asset model as per asset registration v2 #3458
Conversation
✅ Deploy Preview for care-egov-staging ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
👋 Hi, @rithviknishad, This message is automatically generated by prince-chrismc/label-merge-conflicts-action so don't hesitate to report issues/improvements there. |
Kudos, SonarCloud Quality Gate passed! 0 Bugs No Coverage information |
@rithviknishad In the weekly call, we discussed about the two scroller been coming out in the asset creation page, are you working on it now or will it be a another PR coming after this one is merged ! |
@nihal467 I'll make it as another PR then, since this PR has lot's of changes, its getting merge conflicts pretty quickly. |
i feel like the card is little bit towards down, shall we move a bit up, just an opinion, what do you think, |
@rithviknishad @khavinshankar seem like a small alignment issue, we can work on another PR, this LGTM, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@rithviknishad the ui looks awesome, and if you have time do refactor classname using clsx which improves the readability, I'm merging this, so pick it up as a new pr
Closes #3426
as part of #2212
In the Asset Create/Update and Asset Detail page:
warranty_details
removed from the Asset Create/Update and Asset DetailAdditional changes:
Implements hook:
useVisibility
Usage Example:
Implemented Tailwind component:
TextInputFieldV2
Usage example:
Updated Tailwind component:
SelectMenu
with new designAlso fixed it's overflow issues.
Usage Example:
Implemented Tailwind component
RadioInputsV2
Usage example:
Implemented Tailwind Component
SwitchV2