Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added functionality to change consultation file name in files tab #3495

Closed
wants to merge 8 commits into from
Closed

Added functionality to change consultation file name in files tab #3495

wants to merge 8 commits into from

Conversation

patelaryan7751
Copy link
Contributor

@patelaryan7751 patelaryan7751 commented Aug 28, 2022 •
edited
Loading

Proposed Changes

Fixes #3367

  • Added functionality to change file name this operation is available to user who created the file.

Video
https://www.loom.com/share/239b82a74c9b47ebb2d07e4ced007a23

EDIT:

NEW UI

image

@coronasafe/care-fe-code-reviewers @coronasafe/code-reviewers

Merge Checklist

  • Add specs that demonstrate bug / test a new feature.
  • Update product documentation.
  • Ensure that UI text is kept in I18n files.
  • Prep screenshot or demo video for changelog entry, and attach it to issue.
  • Request for Peer Reviews
  • Completion of QA

@patelaryan7751 patelaryan7751 requested a review from a team August 28, 2022 16:03
@patelaryan7751 patelaryan7751 requested a review from a team as a code owner August 28, 2022 16:03
@netlify
Copy link

netlify bot commented Aug 28, 2022 •
edited
Loading

✅ Deploy Preview for care-egov-staging ready!

Name Link
🔨 Latest commit 9dff707
🔍 Latest deploy log https://app.netlify.com/sites/care-egov-staging/deploys/631f2aeef7c43a00094df3fe
😎 Deploy Preview https://deploy-preview-3495--care-egov-staging.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@nihal467
Copy link
Member

@patelaryan7751
image

  • make the button of the same length in responsive view

image

  • once I select the button and click cancel, it always seems like selected

@patelaryan7751
Copy link
Contributor Author

patelaryan7751 commented Sep 3, 2022 •
edited
Loading

@nihal467 i have fixed all bugs updated UI to as disscused in EOD

new UI :
image

Samsung Fold :
image

@sonarcloud
Copy link

sonarcloud bot commented Sep 12, 2022

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 3 Code Smells

No Coverage information No Coverage information
5.3% 5.3% Duplication

@patelaryan7751
Copy link
Contributor Author

new Ui
image
more icons to be added for all types of file when this PR ohcnetwork/care#1019 is meged

@patelaryan7751 patelaryan7751 added waiting for related PR a co-related detail PR is under construction and removed needs review labels Sep 12, 2022
@Ashesh3
Copy link
Member

Ashesh3 commented Sep 23, 2022

This PR appears to be related to this issue: #3366

@aparnacoronasafe suggested an archive option rather than a delete button

@mathew-alex mathew-alex added the merge conflict pull requests with merge conflict label Sep 27, 2022
@mathew-alex
Copy link
Contributor

👋 Hi, @patelaryan7751,
Conflicts have been detected against the base branch. Please rebase your branch against the base branch.

This message is automatically generated by prince-chrismc/label-merge-conflicts-action so don't hesitate to report issues/improvements there.

@patelaryan7751 patelaryan7751 changed the title Added functionality to delete and change consultation file name in files tab Added functionality to change consultation file name in files tab Oct 2, 2022
@patelaryan7751
Copy link
Contributor Author

a new PR has been created to work on this #3716

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bodhish bodhish Awaiting requested review from bodhish

Assignees
No one assigned
Labels
merge conflict pull requests with merge conflict waiting for related PR a co-related detail PR is under construction work-in-progress
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

File Upload: file rename permission to owner
4 participants
@patelaryan7751 @nihal467 @Ashesh3 @mathew-alex