Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Increase input width for Patient Investigation #3539

Merged
merged 3 commits into from
Sep 27, 2022

Conversation

Ashesh3
Copy link
Member

@Ashesh3 Ashesh3 commented Sep 5, 2022

Fixes #3535

Input fields are now big enough for the user to enter and review the data.

msedge_txzHeA9XZA

@Ashesh3 Ashesh3 requested a review from a team September 5, 2022 06:18
@Ashesh3 Ashesh3 requested a review from a team as a code owner September 5, 2022 06:18
@Ashesh3 Ashesh3 requested a review from gigincg September 5, 2022 06:18
@netlify
Copy link

netlify bot commented Sep 5, 2022

Deploy Preview for care-egov-staging ready!

Name Link
🔨 Latest commit ced59fe
🔍 Latest deploy log https://app.netlify.com/sites/care-egov-staging/deploys/63305a2c1fa5cd0008091ad6
😎 Deploy Preview https://deploy-preview-3539--care-egov-staging.netlify.app/
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@rabilrbl
Copy link
Contributor

rabilrbl commented Sep 5, 2022

@Ashesh3 The UI is a bit confusing in small screens
Can we have flex-col so that fields stack in mobile devices?

@Ashesh3
Copy link
Member Author

Ashesh3 commented Sep 5, 2022

@Ashesh3 The UI is a bit confusing in small screens Can we have flex-col so that fields stack in mobile devices?

I agree that the table is a bit hard to navigate on smaller screens but I am afraid I am aware of no better solution. MaterialUI Table does not allow us to display the cells stacked according to the screen size.

https://mui.com/material-ui/api/table/

Although we can indeed force the cells to stack, this might not achieve the best results:
image

I believe that at it's current state (with this PR), it makes the table at least fully usable and represents it in an elegant manner.
If you know of any better way, feel free to suggest a change!

@nihal467
Copy link
Member

nihal467 commented Sep 7, 2022

@rabilrbl @Ashesh3 see a conversation here, once you finalise it, change the label to need testing

@Ashesh3
Copy link
Member Author

Ashesh3 commented Sep 7, 2022

@rabilrbl Which design looks better for you?

@rabilrbl
Copy link
Contributor

rabilrbl commented Sep 7, 2022

@Ashesh3 Reached out to @gigincg told me @aparnacoronasafe Will confirm whether this UI is confusing or not.

@rabilrbl
Copy link
Contributor

rabilrbl commented Sep 7, 2022

@rabilrbl Which design looks better for you?

Obviously the first one.

@Ashesh3
Copy link
Member Author

Ashesh3 commented Sep 7, 2022

@Ashesh3 Reached out to @gigincg told me @aparnacoronasafe Will confirm whether this UI is confusing or not.

Sure! Please do let me know here once you have an update on that.

@Ashesh3
Copy link
Member Author

Ashesh3 commented Sep 15, 2022

@rabilrbl @aparnacoronasafe Any updates on this?

@nihal467
Copy link
Member

@Ashesh3 what is the status

@Ashesh3
Copy link
Member Author

Ashesh3 commented Sep 25, 2022

@Ashesh3 what is the status

No changes are required to this PR. The suggested stacked table looks odd, for now the original design of this PR can be tested and implemented.

@nihal467
Copy link
Member

@Ashesh3 merge the latest development to this PR

@Ashesh3
Copy link
Member Author

Ashesh3 commented Sep 25, 2022

@Ashesh3 merge the latest development to this PR

Done

@nihal467
Copy link
Member

@Ashesh3
image
image

the UI is breaking everywhere, can you check it in normal view

@Ashesh3
Copy link
Member Author

Ashesh3 commented Sep 25, 2022

Should be fixed now:

image

image

@sonarcloud
Copy link

sonarcloud bot commented Sep 25, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
44.4% 44.4% Duplication

@nihal467
Copy link
Member

test approved

@khavinshankar khavinshankar merged commit 831fcc6 into ohcnetwork:develop Sep 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Make Investigation Creation in Patient Page Responsive
4 participants