Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make Patient Form UI responsive #3570

Merged
merged 2 commits into from
Sep 21, 2022
Merged

Make Patient Form UI responsive #3570

merged 2 commits into from
Sep 21, 2022

Conversation

Ashesh3
Copy link
Member

@Ashesh3 Ashesh3 commented Sep 10, 2022

Fixes #3534

@coronasafe/care-fe-code-reviewers @coronasafe/code-reviewers

msedge_f1lRfM0nqL

@Ashesh3 Ashesh3 requested a review from a team September 10, 2022 17:48
@Ashesh3 Ashesh3 requested a review from a team as a code owner September 10, 2022 17:48
@netlify
Copy link

netlify bot commented Sep 10, 2022 •
edited
Loading

✅ Deploy Preview for care-egov-staging ready!

Name Link
🔨 Latest commit f5bd3be
🔍 Latest deploy log https://app.netlify.com/sites/care-egov-staging/deploys/6322d30c1c82880009b5fe60
😎 Deploy Preview https://deploy-preview-3570--care-egov-staging.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@nihal467
Copy link
Member

@Ashesh3
image

  • make the buttons also aligned
  • the admit and confirm both buttons size are bit feel increase, was it intentional

@Ashesh3
Copy link
Member Author

Ashesh3 commented Sep 12, 2022 •
edited
Loading

@Ashesh3 image

  • the admit and confirm both buttons size are bit feel increase, was it intentional
  • make the buttons also aligned

The admit and confirm buttons have minor padding added to them and rounded the shape. This makes them looks better especially on smaller screens, otherwise the text touches the border of the button.

I will make the buttons aligned.

@Ashesh3
Copy link
Member Author

Ashesh3 commented Sep 15, 2022

  • make the buttons also aligned

@sonarcloud
Copy link

sonarcloud bot commented Sep 15, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 2 Code Smells

No Coverage information No Coverage information
0.9% 0.9% Duplication

developedBySJ
developedBySJ approved these changes Sep 16, 2022
View reviewed changes
Copy link
Contributor

@developedBySJ developedBySJ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nihal467
Copy link
Member

test approved

@khavinshankar khavinshankar merged commit 3be9ad9 into ohcnetwork:develop Sep 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@developedBySJ developedBySJ developedBySJ approved these changes

@khavinshankar khavinshankar khavinshankar approved these changes

@rithviknishad rithviknishad rithviknishad approved these changes

@mathew-alex mathew-alex Awaiting requested review from mathew-alex

Assignees
No one assigned
Labels
good to merge tested
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Patient Form UI is not responsive
5 participants
@Ashesh3 @nihal467 @rithviknishad @khavinshankar @developedBySJ