-
Notifications
You must be signed in to change notification settings - Fork 437
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update files list after upload #3580
Conversation
✅ Deploy Preview for care-egov-staging ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
now the page is auto-refreshed, but the file name is still there under the box, can you fix that also |
That should only happen if the file upload fails, I've added an error message when that happens. |
my connection is more than 4 mbps and iam unable to upload the files |
@nihal467 Your internet connection isn't the issue here, it seems that the CORS misconfiguration Mathew mentioned was not resolved when you tried the upload (I had the same issue). The browser will report such errors are Network errors, since it's not able to contact the Edit: File uploads will not work for any domain other than
|
test approved |
Kudos, SonarCloud Quality Gate passed! 0 Bugs No Coverage information |
It seems like file uploads are still failing for local and netlify deployments (develop branch) but working fine on staging. |
Is it still failing? |
|
The deploy preview for staging is also added in CORS policy now. Should be working from now on. |
@Ashesh3 can you check the cypress test |
The Failing tests are totally unrelated to the PR and as Vignesh mentioned 2 days back, Cypress tests are broken in the current state and are to be ignored until they are fixed. |
Partially Fixes #3579
This PR changes when the file list is refreshed and makes it happen only after the upload is fully processed. This makes sure that the new file list contains information about the last upload action regardless of the success.