Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Hide live feed for discharged patients #3631

Merged
merged 2 commits into from
Sep 29, 2022
Merged

Hide live feed for discharged patients #3631

merged 2 commits into from
Sep 29, 2022

Conversation

Ashesh3
Copy link
Member

@Ashesh3 Ashesh3 commented Sep 23, 2022

Fixes #3625

Proposed Changes

  • Hide the live feed for discharged patients

@coronasafe/care-fe-code-reviewers @coronasafe/code-reviewers

image

@Ashesh3 Ashesh3 requested a review from a team September 23, 2022 15:13
@Ashesh3 Ashesh3 requested a review from a team as a code owner September 23, 2022 15:13
@netlify
Copy link

netlify bot commented Sep 23, 2022 •
edited
Loading

✅ Deploy Preview for care-egov-staging ready!

Name Link
🔨 Latest commit 9f7471b
🔍 Latest deploy log https://app.netlify.com/sites/care-egov-staging/deploys/6333e2b13c7ee7000a303362
😎 Deploy Preview https://deploy-preview-3631--care-egov-staging.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@nihal467
Copy link
Member

@Ashesh3

image

https://care.coronasafe.in/facility/ba2f8df6-20e6-4351-b2a3-065d7886e11a/patient/c2e3ce12-44bb-4db1-bcc8-dcbea9843edc/consultation/215fa91e-80e7-4fd9-bf53-4e841bd5a024

iam having two type of waveform in the deploy preview and staaging, for a same patient, is there anything wrong with the PR

@nihal467 nihal467 added question Further information is requested needs testing and removed needs testing labels Sep 28, 2022
@Ashesh3
Copy link
Member Author

Ashesh3 commented Sep 28, 2022

@nihal467 That shouldn't happen, this PR is pure cosmetic change, it just hides the live feed tab if the person has a discharge date. That's it. It doesn't alter anything else anywhere. It shouldn't affect the graphs at all. I'll test this once locally and with other deployments and update here.

@sonarcloud
Copy link

sonarcloud bot commented Sep 28, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
2.7% 2.7% Duplication

@Ashesh3
Copy link
Member Author

Ashesh3 commented Sep 28, 2022

@nihal467 That happened because this PR was quite behind the develop branch, merged now, the graph should be the same both sides.

image

@Ashesh3 Ashesh3 added needs testing and removed needs testing question Further information is requested labels Sep 28, 2022
@nihal467
Copy link
Member

test approved

@khavinshankar khavinshankar merged commit 3326250 into ohcnetwork:develop Sep 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@khavinshankar khavinshankar khavinshankar approved these changes

@vigneshhari vigneshhari Awaiting requested review from vigneshhari

Assignees
No one assigned
Labels
tested
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Remove Live Data for Discharged Patients
3 participants
@Ashesh3 @nihal467 @khavinshankar