Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Resolved UI issue on Inventory management page #3633

Merged
merged 8 commits into from
Sep 28, 2022
Merged

Resolved UI issue on Inventory management page #3633

merged 8 commits into from
Sep 28, 2022

Conversation

Pranshu1902
Copy link
Contributor

@Pranshu1902 Pranshu1902 commented Sep 24, 2022 •
edited
Loading

@Pranshu1902 Pranshu1902 requested a review from a team September 24, 2022 05:49
@Pranshu1902 Pranshu1902 requested a review from a team as a code owner September 24, 2022 05:49
@netlify
Copy link

netlify bot commented Sep 24, 2022 •
edited
Loading

✅ Deploy Preview for care-egov-staging ready!

Name Link
🔨 Latest commit 8c13667
🔍 Latest deploy log https://app.netlify.com/sites/care-egov-staging/deploys/6332f468c5d63500092c9be4
😎 Deploy Preview https://deploy-preview-3633--care-egov-staging.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

patelaryan7751
patelaryan7751 suggested changes Sep 27, 2022
View reviewed changes
Copy link
Contributor

@patelaryan7751 patelaryan7751 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can use Tailwind CSS classes to have the buttons instead of using Material UI. It's a step more towards removing usage of Material UI.

@Pranshu1902
Copy link
Contributor Author

Updated view: (removed Materiall UI Buttons)
image

@nihal467
Copy link
Member

test approved

khavinshankar
khavinshankar reviewed Sep 27, 2022
View reviewed changes
Copy link
Member

@khavinshankar khavinshankar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Pranshu1902 can also refactor the material ui buttons in src/Components/Facility/AddInventoryForm.tsx component also

@Pranshu1902
Copy link
Contributor Author

@khavinshankar done

@mathew-alex
Copy link
Contributor

👋 Hi, @Pranshu1902,
Conflicts have been detected against the base branch. Please rebase your branch against the base branch.

This message is automatically generated by prince-chrismc/label-merge-conflicts-action so don't hesitate to report issues/improvements there.

@mathew-alex mathew-alex added the merge conflict pull requests with merge conflict label Sep 27, 2022
@Pranshu1902 Pranshu1902 removed the merge conflict pull requests with merge conflict label Sep 27, 2022
@netlify
Copy link

netlify bot commented Sep 27, 2022 •
edited
Loading

❌ Deploy Preview for care-net failed.

Name Link
🔨 Latest commit 0ac2aab
🔍 Latest deploy log https://app.netlify.com/sites/care-net/deploys/6332f352ef9f7f000888a29a

@sonarcloud
Copy link

sonarcloud bot commented Sep 27, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@khavinshankar khavinshankar merged commit dc3f644 into ohcnetwork:develop Sep 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@patelaryan7751 patelaryan7751 patelaryan7751 requested changes

@khavinshankar khavinshankar khavinshankar approved these changes

@bodhish bodhish Awaiting requested review from bodhish

Assignees
No one assigned
Labels
tested
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Minor UI fix on Inventory Management Page
5 participants
@Pranshu1902 @nihal467 @mathew-alex @khavinshankar @patelaryan7751