Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Resolved loader not working on External Results page #3662

Merged
merged 2 commits into from
Oct 4, 2022
Merged

Resolved loader not working on External Results page #3662

merged 2 commits into from
Oct 4, 2022

Conversation

Pranshu1902
Copy link
Contributor

Fixes #3661

Loader is visible to the user until the data has been fetched rather than "No data found"
https://www.loom.com/share/e93cda2420504e0eb47648867c65f3fb

@Pranshu1902 Pranshu1902 requested a review from a team September 29, 2022 07:48
@Pranshu1902 Pranshu1902 requested a review from a team as a code owner September 29, 2022 07:48
@netlify
Copy link

netlify bot commented Sep 29, 2022 •
edited
Loading

✅ Deploy Preview for care-egov-staging ready!

Name Link
🔨 Latest commit 27948ac
🔍 Latest deploy log https://app.netlify.com/sites/care-egov-staging/deploys/63396ee53aabdb0008ee8887
😎 Deploy Preview https://deploy-preview-3662--care-egov-staging.netlify.app/
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

Ashesh3
Ashesh3 requested changes Oct 2, 2022
View reviewed changes
Copy link
Member

@Ashesh3 Ashesh3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The Total Result count should also be in a loading state and not display as 0 immediately.

Current:
image

Expected:
image

@Pranshu1902
Copy link
Contributor Author

Pranshu1902 commented Oct 2, 2022 •
edited
Loading

Updated view:
Added loader for Total Results
image

@sonarcloud
Copy link

sonarcloud bot commented Oct 2, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@nihal467
Copy link
Member

nihal467 commented Oct 4, 2022

test approved

@khavinshankar khavinshankar merged commit add2713 into ohcnetwork:develop Oct 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Ashesh3 Ashesh3 Ashesh3 requested changes

@khavinshankar khavinshankar khavinshankar approved these changes

@vigneshhari vigneshhari Awaiting requested review from vigneshhari

Assignees
No one assigned
Labels
tested
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Loader not working on External results page
4 participants
@Pranshu1902 @nihal467 @Ashesh3 @khavinshankar