Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Made asset warranty card responsive in extreme small devices #3680

Merged
merged 3 commits into from
Oct 4, 2022
Merged

Made asset warranty card responsive in extreme small devices #3680

merged 3 commits into from
Oct 4, 2022

Conversation

patelaryan7751
Copy link
Contributor

@patelaryan7751 patelaryan7751 commented Oct 1, 2022 •
edited
Loading

Proposed Changes

Fixes #3675
Made asset warranty card responsive in extreme small devices
image

@coronasafe/care-fe-code-reviewers @coronasafe/code-reviewers

Merge Checklist

  • Add specs that demonstrate bug / test a new feature.
  • Update product documentation.
  • Ensure that UI text is kept in I18n files.
  • Prep screenshot or demo video for changelog entry, and attach it to issue.
  • Request for Peer Reviews
  • Completion of QA

@patelaryan7751 patelaryan7751 requested a review from a team October 1, 2022 12:39
@patelaryan7751 patelaryan7751 requested a review from a team as a code owner October 1, 2022 12:39
@netlify
Copy link

netlify bot commented Oct 1, 2022 •
edited
Loading

✅ Deploy Preview for care-egov-staging ready!

Name Link
🔨 Latest commit 7535794
🔍 Latest deploy log https://app.netlify.com/sites/care-egov-staging/deploys/633a76e65e4bcd0009f2a399
😎 Deploy Preview https://deploy-preview-3680--care-egov-staging.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

Ashesh3
Ashesh3 requested changes Oct 2, 2022
View reviewed changes
Copy link
Member

@Ashesh3 Ashesh3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image

Can we make the two cards uniform and fix the alignment for the buttons?

@rithviknishad
Copy link
Member

@patelaryan7751 the button layout is fixed in #3681

@patelaryan7751
Copy link
Contributor Author

Hey @Ashesh3 yeah sure i am working on it.

@patelaryan7751
Copy link
Contributor Author

Hey @rithviknishad then i am working on the alignment issue .

@sonarcloud
Copy link

sonarcloud bot commented Oct 3, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

Ashesh3
Ashesh3 approved these changes Oct 3, 2022
View reviewed changes
Copy link
Member

@Ashesh3 Ashesh3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nihal467
Copy link
Member

nihal467 commented Oct 4, 2022

test approved

@khavinshankar khavinshankar merged commit 1702725 into ohcnetwork:develop Oct 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@khavinshankar khavinshankar khavinshankar approved these changes

@Ashesh3 Ashesh3 Ashesh3 approved these changes

@bodhish bodhish Awaiting requested review from bodhish

@rithviknishad rithviknishad Awaiting requested review from rithviknishad

Assignees
No one assigned
Labels
hacktoberfest hacktoberfest-accepted tested
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Asset Details is not responsive in extreme small devices
5 participants
@patelaryan7751 @rithviknishad @nihal467 @Ashesh3 @khavinshankar