Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make Patient summary plots responsive #3699

Merged
merged 3 commits into from
Oct 13, 2022

Conversation

Ashesh3
Copy link
Member

@Ashesh3 Ashesh3 commented Oct 3, 2022

Fixes #3642

Now

image

Before

image

@coronasafe/care-fe-code-reviewers @coronasafe/code-reviewers

@Ashesh3 Ashesh3 requested a review from a team October 3, 2022 14:20
@Ashesh3 Ashesh3 requested a review from a team as a code owner October 3, 2022 14:20
@netlify
Copy link

netlify bot commented Oct 3, 2022

Deploy Preview for care-egov-staging ready!

Name Link
🔨 Latest commit 2dbebd7
🔍 Latest deploy log https://app.netlify.com/sites/care-egov-staging/deploys/633de4642a315c00095d8096
😎 Deploy Preview https://deploy-preview-3699--care-egov-staging.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

Copy link
Contributor

@patelaryan7751 patelaryan7751 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @Ashesh3 Everything seems fine.
A bit enhancement if possible the september is being hidden a bit. Rest all is Good.
Patient Name: Nancy
image

@nihal467
Copy link
Member

nihal467 commented Oct 4, 2022

@Ashesh3 once the work is completed , change it to need testing

@Ashesh3
Copy link
Member Author

Ashesh3 commented Oct 4, 2022

Fixed.
image
image
image

@nihal467
Copy link
Member

nihal467 commented Oct 5, 2022

@Ashesh3
image

the graph icons are overlapping

@Ashesh3
Copy link
Member Author

Ashesh3 commented Oct 5, 2022

@nihal467 Should be fixed now.

image

@sonarcloud
Copy link

sonarcloud bot commented Oct 5, 2022

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
13.4% 13.4% Duplication

@Ashesh3
Copy link
Member Author

Ashesh3 commented Oct 11, 2022

@nihal467
Copy link
Member

test approved

@khavinshankar khavinshankar merged commit c5cf7b8 into ohcnetwork:develop Oct 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Data in graphs in summary page is being hidden in mobile devices
4 participants