Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue 2962 - scroll to top if in whitelist #3731

Merged
merged 3 commits into from
Oct 13, 2022

Conversation

Ritesh-Aggarwal
Copy link
Contributor

@Ritesh-Aggarwal Ritesh-Aggarwal commented Oct 8, 2022

Proposed Changes

@coronasafe/care-fe-code-reviewers @coronasafe/code-reviewers

Merge Checklist

  • Add specs that demonstrate bug / test a new feature.
  • Update product documentation.
  • Ensure that UI text is kept in I18n files.
  • Prep screenshot or demo video for changelog entry, and attach it to issue.
  • Request for Peer Reviews
  • Completion of QA

@netlify
Copy link

netlify bot commented Oct 8, 2022

Deploy Preview for care-egov-staging ready!

Name Link
🔨 Latest commit ff94adf
🔍 Latest deploy log https://app.netlify.com/sites/care-egov-staging/deploys/634696c56ec2920008c5b7f9
😎 Deploy Preview https://deploy-preview-3731--care-egov-staging.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@nihal467
Copy link
Member

test approved

@khavinshankar
Copy link
Member

@Ritesh-Aggarwal can you double-check it once again, when I go to the pressure sore tab, it scrolls to the top, also when I go to a different tab and go back to updates, it scrolls back to the top, also check other tabs too

@sonarcloud
Copy link

sonarcloud bot commented Oct 12, 2022

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell B 6 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@Ritesh-Aggarwal
Copy link
Contributor Author

Ritesh-Aggarwal commented Oct 12, 2022

going to updates tab will always scroll to top that is the expected behavior
I have fixed the pressure sore tab and checked all other tabs
good to go now
@khavinshankar

@nihal467
Copy link
Member

test approved

@khavinshankar khavinshankar merged commit a21cffb into ohcnetwork:develop Oct 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

In Patient Dashboard Page while changing tabs the scroll bar is coming to top of page in mobile devices
3 participants