Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Proxy camera feed PTZ requests through backend #3767

Merged
merged 10 commits into from
Nov 23, 2022
Merged

Proxy camera feed PTZ requests through backend #3767

merged 10 commits into from
Nov 23, 2022

Conversation

rabilrbl
Copy link
Contributor

@rabilrbl rabilrbl commented Oct 16, 2022 •
edited
Loading

Resolves #3512

Proposed Changes

  • Proxy all camera feed PTZ requests through backend

@netlify
Copy link

netlify bot commented Oct 16, 2022 •
edited
Loading

✅ Deploy Preview for care-egov-staging ready!

Name Link
🔨 Latest commit b01ebba
🔍 Latest deploy log https://app.netlify.com/sites/care-egov-staging/deploys/637b0874de945b0009d82244
😎 Deploy Preview https://deploy-preview-3767--care-egov-staging.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@rabilrbl rabilrbl changed the title Update feed ptz requests Proxy camera feed PTZ requests through backend Oct 16, 2022
@rabilrbl rabilrbl marked this pull request as ready for review October 17, 2022 14:06
@rabilrbl rabilrbl requested a review from a team October 17, 2022 14:06
@rabilrbl rabilrbl requested a review from a team as a code owner October 17, 2022 14:06
@nihal467
Copy link
Member

image

@khavinshankar it looks good to me, can you give it a detailed look

@nihal467
Copy link
Member

@rabilrbl
image
when we click on the default presets , the page goes white

@github-actions github-actions bot added the merge conflict pull requests with merge conflict label Oct 20, 2022
@github-actions
Copy link

👋 Hi, @rabilrbl,
Conflicts have been detected against the base branch. Please rebase your branch against the base branch.

This message is automatically generated by prince-chrismc/label-merge-conflicts-action so don't hesitate to report issues/improvements there.

@github-actions
Copy link

Hi, This pr has been automatically marked as stale because it has not had any recent activity. It will be automatically closed if no further activity occurs for 7 more days. Thank you for your contributions.

@github-actions github-actions bot added the stale label Oct 28, 2022
@vercel
Copy link

vercel bot commented Oct 31, 2022 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
care-storybook ✅ Ready (Inspect) Visit Preview Nov 21, 2022 at 5:13AM (UTC)

@rabilrbl rabilrbl removed stale merge conflict pull requests with merge conflict labels Oct 31, 2022
@rabilrbl
Copy link
Contributor Author

@nihal467 I haven't made any UI changes in this PR.
Could you please verify if the same issue persist in default staging server?

@rabilrbl rabilrbl added the question Further information is requested label Oct 31, 2022
@nihal467
Copy link
Member

nihal467 commented Nov 8, 2022

@rabilrbl
image

https://care.coronasafe.in/assets/e0744026-5017-489d-9636-72379436ca1c/configure
https://deploy-preview-3767--care-net.netlify.app/assets/e0744026-5017-489d-9636-72379436ca1c/configure

the issue this persist, when you click on default presets, the page goes white and this issue is only happening in your PR not in the current staging

@nihal467 nihal467 added test failed and removed question Further information is requested needs testing labels Nov 8, 2022
@github-actions
Copy link

Hi, This pr has been automatically marked as stale because it has not had any recent activity. It will be automatically closed if no further activity occurs for 7 more days. Thank you for your contributions.

@github-actions github-actions bot added the stale label Nov 17, 2022
@github-actions github-actions bot removed the stale label Nov 19, 2022
@sonarcloud
Copy link

sonarcloud bot commented Nov 21, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@nihal467
Copy link
Member

nihal467 commented Nov 23, 2022 •
edited
Loading

LGTM

@khavinshankar khavinshankar merged commit 161ca8d into ohcnetwork:develop Nov 23, 2022
aeswibon pushed a commit to aeswibon/care_fe that referenced this pull request Dec 8, 2022
@rabilrbl @developedBySJ @aeswibon
Proxy camera feed PTZ requests through backend (ohcnetwork#3767)
1ff64aa 
* Add redux api endpoints for operate asset

* Remove unwanted type attr

- Refactored code

* Proxy all middleware request through backend

- Remove axios
- adapt types

* Remove `middlewareHostname`: not used

* Refactor error handling

* Fix bug

Co-authored-by: developedBySJ <developedbysj@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@developedBySJ developedBySJ developedBySJ approved these changes

@khavinshankar khavinshankar khavinshankar approved these changes

@vigneshhari vigneshhari Awaiting requested review from vigneshhari

Assignees
No one assigned
Labels
tested
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Proxy all camera feed PTZ requests through back end
5 participants
@rabilrbl @nihal467 @khavinshankar @developedBySJ @gigincg