Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added Home Facility name beside doctors name while assigning doctor in Consutation Page #3897

Merged
merged 4 commits into from
Nov 9, 2022
Merged

Added Home Facility name beside doctors name while assigning doctor in Consutation Page #3897

merged 4 commits into from
Nov 9, 2022

Conversation

patelaryan7751
Copy link
Contributor

Proposed Changes

Fixes #3862

Added Home Facility name beside doctors name while assigning doctor in Consutation Page
image

@coronasafe/care-fe-code-reviewers @coronasafe/code-reviewers

Merge Checklist

  • Add specs that demonstrate bug / test a new feature.
  • Update product documentation.
  • Ensure that UI text is kept in I18n files.
  • Prep screenshot or demo video for changelog entry, and attach it to issue.
  • Request for Peer Reviews
  • Completion of QA

@patelaryan7751 patelaryan7751 requested a review from a team October 31, 2022 10:34
@patelaryan7751 patelaryan7751 requested a review from a team as a code owner October 31, 2022 10:34
@vercel
Copy link

vercel bot commented Oct 31, 2022 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
care-storybook ✅ Ready (Inspect) Visit Preview Nov 9, 2022 at 10:49AM (UTC)

@netlify
Copy link

netlify bot commented Oct 31, 2022 •
edited
Loading

✅ Deploy Preview for care-egov-staging ready!

Name Link
🔨 Latest commit 9ea616f
🔍 Latest deploy log https://app.netlify.com/sites/care-egov-staging/deploys/636b856acf004300082a614b
😎 Deploy Preview https://deploy-preview-3897--care-egov-staging.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@nihal467
Copy link
Member

nihal467 commented Nov 1, 2022

test approved

khavinshankar
khavinshankar requested changes Nov 1, 2022
View reviewed changes
Copy link
Member

@khavinshankar khavinshankar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just couple refactors

src/Components/Users/models.tsx Outdated Show resolved Hide resolved
src/Components/Users/models.tsx Outdated Show resolved Hide resolved
rithviknishad
rithviknishad approved these changes Nov 6, 2022
View reviewed changes
Copy link
Member

@rithviknishad rithviknishad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@khavinshankar @nihal467 @patelaryan7751 how about showing the associated facility without "@" prefix but in text-gray-700 instead of having "@ facility name"?

@khavinshankar
Copy link
Member

@khavinshankar @nihal467 @patelaryan7751 how about showing the associated facility without "@" prefix but in text-gray-700 instead of having "@ facility name"?

that's a nice idea

@sonarcloud
Copy link

sonarcloud bot commented Nov 9, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@khavinshankar
Copy link
Member

khavinshankar commented Nov 9, 2022 •
edited
Loading

@nihal467 can you retest this pr

image

greyed out the facility name instead of @ facility name

@nihal467
Copy link
Member

nihal467 commented Nov 9, 2022

test approved

@nihal467 nihal467 added the tested label Nov 9, 2022
@khavinshankar khavinshankar merged commit de5c65e into ohcnetwork:develop Nov 9, 2022
aeswibon pushed a commit to aeswibon/care_fe that referenced this pull request Dec 8, 2022
@patelaryan7751 @khavinshankar @aeswibon
Added Home Facility name beside doctors name while assigning doctor i…
4cdec34 
…n Consutation Page (ohcnetwork#3897)

* Added Home Facility name beside doctors name while assigning doctor in Consutation Page

* refactored the code

* Update src/Components/Common/OnlineUsersSelect.tsx

Co-authored-by: Khavin Shankar <khavinshankar@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@khavinshankar khavinshankar khavinshankar approved these changes

@rithviknishad rithviknishad rithviknishad approved these changes

@gigincg gigincg Awaiting requested review from gigincg

Assignees
No one assigned
Labels
tested
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Different Doctors with same name can't be differentiated in telemedicine
4 participants
@patelaryan7751 @nihal467 @khavinshankar @rithviknishad