-
Notifications
You must be signed in to change notification settings - Fork 437
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Show password requirement error during input #3934
Conversation
✅ Deploy Preview for care-egov-staging ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
@Ashesh3 the PR LGTM, and it serve the purpose. Iam marking it team discussion required since i feel like making it similar to the username validation is good, don't work on this comment until it is approved in today's EOD |
@Ashesh3 as we discussed in the EOD, make the requirement of password been shown similar to the username |
@nihal467 Done. |
even if the password column is empty, it is saying confirmed. can you fix it, like someone type a single character, then only this condition start coming |
@nihal467 Done. |
test approved |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Ashesh3 can you make a separate component or function for the validation rules, something like,
const validationRule = (valid, content) => {
return (
<div>
{valid ? (
<i className="fas fa-circle-xmark text-red-500" />
) : (
<i className="fas fa-circle-check text-green-500" />
)}{" "}
<span
className={clsx(
valid
? "text-red-500"
: "text-primary-500"
)}
>
{content}
</span>
</div>
)
}
👋 Hi, @Ashesh3, This message is automatically generated by prince-chrismc/label-merge-conflicts-action so don't hesitate to report issues/improvements there. |
That's a good suggestion, definitely makes the code cleaner. Done! |
SonarCloud Quality Gate failed. 0 Bugs No Coverage information |
* Show password requirement error during input * Improve password requirements message design * Minor bug fix * Show confirm password message only if not empty * Move validation to a separate function
Fixes #3907
@coronasafe/care-fe-code-reviewers @coronasafe/code-reviewers