Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added sidebar indicator #3991

Merged
merged 8 commits into from
Nov 9, 2022

Conversation

shivankacker
Copy link
Member

Added a sidebar indicator that animates on page change. Made buttons rounded and decreased horizontal padding.

image

@shivankacker shivankacker requested a review from a team November 7, 2022 10:51
@shivankacker shivankacker requested a review from a team as a code owner November 7, 2022 10:51
@netlify
Copy link

netlify bot commented Nov 7, 2022

Deploy Preview for care-egov-staging ready!

Name Link
🔨 Latest commit 91c223c
🔍 Latest deploy log https://app.netlify.com/sites/care-egov-staging/deploys/63695ac5ccb1c10008193d04
😎 Deploy Preview https://deploy-preview-3991--care-egov-staging.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@vercel
Copy link

vercel bot commented Nov 7, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
care-storybook ✅ Ready (Inspect) Visit Preview Nov 7, 2022 at 7:23PM (UTC)

Copy link
Member

@rithviknishad rithviknishad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@skks1212 two issues:

  1. when no sidebar item is selected, it is showing the indicator near the care logo, can u hide it instead?
    image

  2. The mobile sidebar is affected badly.
    image

@sonarcloud
Copy link

sonarcloud bot commented Nov 7, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 4 Code Smells

No Coverage information No Coverage information
0.5% 0.5% Duplication

@nihal467
Copy link
Member

nihal467 commented Nov 8, 2022

@skks1212 i can see many pushes after its been marked for testing, is it good for testing now

@nihal467 nihal467 added the question Further information is requested label Nov 8, 2022
@shivankacker
Copy link
Member Author

@skks1212 i can see many pushes after its been marked for testing, is it good for testing now

Yes it is 👍

@nihal467 nihal467 removed the question Further information is requested label Nov 8, 2022
@nihal467
Copy link
Member

nihal467 commented Nov 8, 2022

PR LGTM, Marking it as team discussion required for final UI approval

@nihal467
Copy link
Member

nihal467 commented Nov 9, 2022

test approved

@khavinshankar khavinshankar merged commit 7b6115a into ohcnetwork:develop Nov 9, 2022
aeswibon pushed a commit to aeswibon/care_fe that referenced this pull request Dec 8, 2022
* added sidebar indicator

* fixed bugs

* fixed flex-1 for small devices

* fix bug induced from fixing bug

* smoother animations

* my math eventually mathed

* fixed parenting issues

* parenting fix 2
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants