Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

useActiveLink hook for detecting sidebar selected or not. #3993

Merged
merged 3 commits into from
Nov 9, 2022
Merged

useActiveLink hook for detecting sidebar selected or not. #3993

merged 3 commits into from
Nov 9, 2022

Conversation

rithviknishad
Copy link
Member

Proposed Changes

image

image

@coronasafe/care-fe-code-reviewers @coronasafe/code-reviewers

Merge Checklist

  • Add specs that demonstrate bug / test a new feature.
  • Update product documentation.
  • Ensure that UI text is kept in I18n files.
  • Prep screenshot or demo video for changelog entry, and attach it to issue.
  • Request for Peer Reviews
  • Completion of QA

@rithviknishad rithviknishad requested a review from a team November 7, 2022 13:21
@rithviknishad rithviknishad requested a review from a team as a code owner November 7, 2022 13:21
@netlify
Copy link

netlify bot commented Nov 7, 2022 •
edited
Loading

✅ Deploy Preview for care-egov-staging ready!

Name Link
🔨 Latest commit 96841a1
🔍 Latest deploy log https://app.netlify.com/sites/care-egov-staging/deploys/636b8f732299bd000808bfb4
😎 Deploy Preview https://deploy-preview-3993--care-egov-staging.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@vercel
Copy link

vercel bot commented Nov 7, 2022 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
care-storybook ✅ Ready (Inspect) Visit Preview Nov 9, 2022 at 11:32AM (UTC)

@github-actions
Copy link

github-actions bot commented Nov 9, 2022

👋 Hi, @rithviknishad,
Conflicts have been detected against the base branch. Please rebase your branch against the base branch.

This message is automatically generated by prince-chrismc/label-merge-conflicts-action so don't hesitate to report issues/improvements there.

@github-actions github-actions bot added the merge conflict pull requests with merge conflict label Nov 9, 2022
@rithviknishad rithviknishad added needs testing needs review and removed merge conflict pull requests with merge conflict labels Nov 9, 2022
@sonarcloud
Copy link

sonarcloud bot commented Nov 9, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

Ritesh-Aggarwal
Ritesh-Aggarwal approved these changes Nov 9, 2022
View reviewed changes
Copy link
Contributor

@Ritesh-Aggarwal Ritesh-Aggarwal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nihal467
Copy link
Member

nihal467 commented Nov 9, 2022

Lgtm

@khavinshankar khavinshankar merged commit 82a7781 into ohcnetwork:develop Nov 9, 2022
aeswibon pushed a commit to aeswibon/care_fe that referenced this pull request Dec 8, 2022
@rithviknishad @aeswibon
useActiveLink hook for detecting sidebar selected or not. (ohcnetwo…
37765ab 
…rk#3993)

* fix path of `/users/add`

* Sidebar use active link hook
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Ritesh-Aggarwal Ritesh-Aggarwal Ritesh-Aggarwal approved these changes

@khavinshankar khavinshankar khavinshankar approved these changes

@bodhish bodhish Awaiting requested review from bodhish

Assignees
No one assigned
Labels
needs review peer-reviewed tested
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Improve current sidebar tab selected state detection logic
4 participants
@rithviknishad @nihal467 @khavinshankar @Ritesh-Aggarwal