Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

NotificationList: replace legacy select and buttons with tailwind components. #3997

Closed
wants to merge 2 commits into from
Closed

NotificationList: replace legacy select and buttons with tailwind components. #3997

wants to merge 2 commits into from

Conversation

rithviknishad
Copy link
Member

@rithviknishad rithviknishad commented Nov 7, 2022 •
edited
Loading

⚠️ This PR has been merged to #3996 instead.

Proposed Changes

  • Replace old select field with SelectMenuV2
  • Replace legacy buttons with ButtonV2

After

image

image

Before

image

@coronasafe/care-fe-code-reviewers @coronasafe/code-reviewers

Merge Checklist

  • Add specs that demonstrate bug / test a new feature.
  • Update product documentation.
  • Ensure that UI text is kept in I18n files.
  • Prep screenshot or demo video for changelog entry, and attach it to issue.
  • Request for Peer Reviews
  • Completion of QA

@rithviknishad rithviknishad requested a review from a team November 7, 2022 19:30
@rithviknishad rithviknishad requested a review from a team as a code owner November 7, 2022 19:30
@vercel
Copy link

vercel bot commented Nov 7, 2022 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
care-storybook ✅ Ready (Inspect) Visit Preview Nov 7, 2022 at 7:32PM (UTC)

@netlify
Copy link

netlify bot commented Nov 7, 2022 •
edited
Loading

✅ Deploy Preview for care-egov-staging ready!

Name Link
🔨 Latest commit 5d19419
🔍 Latest deploy log https://app.netlify.com/sites/care-egov-staging/deploys/63695ce7abb23d000956a30b
😎 Deploy Preview https://deploy-preview-3997--care-egov-staging.netlify.app/
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@sonarcloud
Copy link

sonarcloud bot commented Nov 7, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@rithviknishad
Copy link
Member Author

Closing as merged to #3996

@rithviknishad rithviknishad mentioned this pull request Nov 8, 2022
Closed
18 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vigneshhari vigneshhari Awaiting requested review from vigneshhari

Assignees
No one assigned
Labels
wont merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@rithviknishad