Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Auto scroll to error on Asset Creation #4053

Merged
merged 2 commits into from
Nov 16, 2022
Merged

Auto scroll to error on Asset Creation #4053

merged 2 commits into from
Nov 16, 2022

Conversation

Ashesh3
Copy link
Member

@Ashesh3 Ashesh3 commented Nov 14, 2022

Fixes #4044

WildSpringtail

@coronasafe/care-fe-code-reviewers @coronasafe/code-reviewers

@Ashesh3 Ashesh3 requested a review from a team November 14, 2022 08:34
@Ashesh3 Ashesh3 requested a review from a team as a code owner November 14, 2022 08:34
@vercel
Copy link

vercel bot commented Nov 14, 2022 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
care-storybook ✅ Ready (Inspect) Visit Preview Nov 15, 2022 at 1:28PM (UTC)

@netlify
Copy link

netlify bot commented Nov 14, 2022 •
edited
Loading

✅ Deploy Preview for care-egov-staging ready!

Name Link
🔨 Latest commit c91f976
🔍 Latest deploy log https://app.netlify.com/sites/care-egov-staging/deploys/6373939e14d60b00081bfdb9
😎 Deploy Preview https://deploy-preview-4053--care-egov-staging.netlify.app/
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@nihal467
Copy link
Member

@Ashesh3

image

not working is breaking in your PR

@Ashesh3
Copy link
Member Author

Ashesh3 commented Nov 15, 2022 •
edited
Loading

@Ashesh3

image

not working is breaking in your PR

It seems to work fine for me. Could you let me know the steps to reproduce the error? And can you also confirm that this issue is not there on staging?

image

@Ashesh3 Ashesh3 added the question Further information is requested label Nov 15, 2022
@nihal467
Copy link
Member

@Ashesh3
Untitled

in your PR, the not working button is written in two rows, but in current staging ,the not working button is written in single row.

@Ashesh3
Copy link
Member Author

Ashesh3 commented Nov 15, 2022

@Ashesh3 Untitled

in your PR, the not working button is written in two rows, but in current staging ,the not working button is written in single row.

Fixed.

image

@Ashesh3 Ashesh3 added needs testing and removed test failed question Further information is requested labels Nov 15, 2022
@sonarcloud
Copy link

sonarcloud bot commented Nov 15, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.1% 0.1% Duplication

@nihal467
Copy link
Member

test approved

@khavinshankar khavinshankar merged commit d9dbd08 into ohcnetwork:develop Nov 16, 2022
aeswibon pushed a commit to aeswibon/care_fe that referenced this pull request Dec 8, 2022
@Ashesh3 @aeswibon
Auto scroll to error on Asset Creation (ohcnetwork#4053)
b901995 
* Auto scroll to error on Asset Creation

* Minor ui fix
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@khavinshankar khavinshankar khavinshankar approved these changes

@mathew-alex mathew-alex Awaiting requested review from mathew-alex

Assignees
No one assigned
Labels
tested
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Auto-scroll to error in asset page on submission
3 participants
@Ashesh3 @nihal467 @khavinshankar