Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed Cypress Tests #4062

Merged
merged 19 commits into from
Dec 12, 2022
Merged

Fixed Cypress Tests #4062

merged 19 commits into from
Dec 12, 2022

Conversation

khavinshankar
Copy link
Member

Proposed Changes

  • asset
  • external results
  • sample tests
  • shifting
  • user

@coronasafe/care-fe-code-reviewers @coronasafe/code-reviewers

Merge Checklist

  • Add specs that demonstrate bug / test a new feature.
  • Update product documentation.
  • Ensure that UI text is kept in I18n files.
  • Prep screenshot or demo video for changelog entry, and attach it to issue.
  • Request for Peer Reviews
  • Completion of QA

@khavinshankar khavinshankar requested a review from a team November 16, 2022 09:05
@khavinshankar khavinshankar requested a review from a team as a code owner November 16, 2022 09:05
@vercel
Copy link

vercel bot commented Nov 16, 2022 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
care-storybook ✅ Ready (Inspect) Visit Preview Dec 12, 2022 at 3:20AM (UTC)

@netlify
Copy link

netlify bot commented Nov 16, 2022 •
edited
Loading

✅ Deploy Preview for care-egov-staging ready!

Name Link
🔨 Latest commit 4a95a25
🔍 Latest deploy log https://app.netlify.com/sites/care-egov-staging/deploys/63969da2c80ff70009fe849a
😎 Deploy Preview https://deploy-preview-4062--care-egov-staging.netlify.app/
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@github-actions github-actions bot added the cypress failed pull request with cypress test failure label Nov 16, 2022
@github-actions github-actions bot removed the cypress failed pull request with cypress test failure label Nov 16, 2022
@github-actions
Copy link

Hi, This pr has been automatically marked as stale because it has not had any recent activity. It will be automatically closed if no further activity occurs for 7 more days. Thank you for your contributions.

@github-actions github-actions bot added stale merge conflict pull requests with merge conflict labels Nov 24, 2022
@github-actions
Copy link

👋 Hi, @khavinshankar,
Conflicts have been detected against the base branch. Please rebase your branch against the base branch.

This message is automatically generated by prince-chrismc/label-merge-conflicts-action so don't hesitate to report issues/improvements there.

@github-actions github-actions bot removed the stale label Nov 25, 2022
@github-actions github-actions bot removed the merge conflict pull requests with merge conflict label Nov 25, 2022
@github-actions github-actions bot added the cypress failed pull request with cypress test failure label Nov 25, 2022
@github-actions github-actions bot removed the cypress failed pull request with cypress test failure label Dec 2, 2022
@github-actions
Copy link

github-actions bot commented Dec 8, 2022

👋 Hi, @khavinshankar,
Conflicts have been detected against the base branch. Please rebase your branch against the base branch.

This message is automatically generated by prince-chrismc/label-merge-conflicts-action so don't hesitate to report issues/improvements there.

@github-actions github-actions bot added the merge conflict pull requests with merge conflict label Dec 8, 2022
@github-actions github-actions bot removed the merge conflict pull requests with merge conflict label Dec 9, 2022
@github-actions github-actions bot added the cypress failed pull request with cypress test failure label Dec 9, 2022
@github-actions
Copy link

github-actions bot commented Dec 9, 2022

👋 Hi, @khavinshankar,
Conflicts have been detected against the base branch. Please rebase your branch against the base branch.

This message is automatically generated by prince-chrismc/label-merge-conflicts-action so don't hesitate to report issues/improvements there.

@github-actions github-actions bot added the merge conflict pull requests with merge conflict label Dec 9, 2022
@github-actions github-actions bot removed the merge conflict pull requests with merge conflict label Dec 12, 2022
@sonarcloud
Copy link

sonarcloud bot commented Dec 12, 2022

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
19.6% 19.6% Duplication

@github-actions github-actions bot removed the cypress failed pull request with cypress test failure label Dec 12, 2022
rithviknishad
rithviknishad approved these changes Dec 12, 2022
View reviewed changes
Copy link
Member

@rithviknishad rithviknishad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@khavinshankar LGTM. How about also hiding the npm run start's logs and just show the output of cypress run?

@gigincg gigincg merged commit ef4ba6f into develop Dec 12, 2022
@gigincg gigincg deleted the fix#cypress branch December 12, 2022 14:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rithviknishad rithviknishad rithviknishad approved these changes

@gigincg gigincg gigincg approved these changes

@riginoommen riginoommen riginoommen approved these changes

@bodhish bodhish Awaiting requested review from bodhish

Assignees
No one assigned
Labels
good to merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@khavinshankar @riginoommen @gigincg @rithviknishad