Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Placeholder and autofill credentials overlap in chrome #4118

Merged
merged 5 commits into from
Dec 17, 2022
Merged

fix: Placeholder and autofill credentials overlap in chrome #4118

merged 5 commits into from
Dec 17, 2022

Conversation

Pragati1610
Copy link
Contributor

fixes #3992

@Pragati1610 Pragati1610 requested a review from a team November 25, 2022 15:36
@Pragati1610 Pragati1610 requested a review from a team as a code owner November 25, 2022 15:36
@netlify
Copy link

netlify bot commented Nov 25, 2022 •
edited
Loading

✅ Deploy Preview for care-egov-staging ready!

Name Link
🔨 Latest commit 3dbadd4
🔍 Latest deploy log https://app.netlify.com/sites/care-egov-staging/deploys/639d6b9601c09e00082f461e
😎 Deploy Preview https://deploy-preview-4118--care-egov-staging.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@vercel
Copy link

vercel bot commented Nov 25, 2022 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
care-storybook ✅ Ready (Inspect) Visit Preview Dec 17, 2022 at 7:13AM (UTC)

@rithviknishad rithviknishad mentioned this pull request Nov 28, 2022
Closed
Ashesh3
Ashesh3 reviewed Nov 30, 2022
View reviewed changes
Copy link
Member

@Ashesh3 Ashesh3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It does the job, but I feel it breaks the original design where the placeholder would be inside the input fields when the form is loaded empty.

Original design (on page load):
image

With this PR (on page load):
image

@nihal467
Copy link
Member

nihal467 commented Dec 6, 2022

@Pragati1610 marking it for team discussion, for reviewing the PR

@gigincg
Copy link
Member

gigincg commented Dec 7, 2022

https://medium.com/weekly-webtips/detecting-chrome-autofill-on-page-load-78ea178e4a68

@Pragati1610 We need to detect autofill and not focus when there is nothing to autofill

Ashesh3
Ashesh3 approved these changes Dec 12, 2022
View reviewed changes
Copy link
Member

@Ashesh3 Ashesh3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works great, tested on Firefox, Edge and Chrome.

@nihal467
Copy link
Member

@Pragati1610 LGTM, great work, Marking it team discussion for final approval

Few points to discuss on EOD

  • the font size on autofill is different compared to the actual one

image

when we click somewhere on the page, the font gets back to normal one

@khavinshankar
Copy link
Member

@nihal467 does this require team discussion or can I go ahead and merge this?

@Ashesh3
Copy link
Member

Ashesh3 commented Dec 15, 2022

@nihal467 does this require team discussion or can I go ahead and merge this?

We discussed it a day back on EOD (after this was marked for discussion), and this was approved. 😄

@khavinshankar khavinshankar added cypress failed pull request with cypress test failure and removed needs review Team Discuss Required labels Dec 15, 2022
@sonarcloud
Copy link

sonarcloud bot commented Dec 17, 2022

SonarCloud Quality Gate failed.    Quality Gate failed

Bug C 1 Bug
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@khavinshankar khavinshankar merged commit bb10806 into ohcnetwork:develop Dec 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@khavinshankar khavinshankar khavinshankar approved these changes

@rithviknishad rithviknishad rithviknishad approved these changes

@Ashesh3 Ashesh3 Ashesh3 approved these changes

@mathew-alex mathew-alex Awaiting requested review from mathew-alex

Assignees
No one assigned
Labels
cypress failed pull request with cypress test failure tested
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Placeholder and autofill credentials overlap in chrome.
6 participants
@Pragati1610 @nihal467 @gigincg @khavinshankar @Ashesh3 @rithviknishad