Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Made sidebar scrollable in small screens and landscape mode #4121

Merged
merged 4 commits into from
Dec 8, 2022

Conversation

khavinshankar
Copy link
Member

Proposed Changes

  • made sidebar scrollable in small screens and landscape mode

@coronasafe/care-fe-code-reviewers @coronasafe/code-reviewers

Merge Checklist

  • Add specs that demonstrate bug / test a new feature.
  • Update product documentation.
  • Ensure that UI text is kept in I18n files.
  • Request for Peer Reviews
  • Completion of QA

cc: @nihal467

@khavinshankar khavinshankar requested a review from a team November 26, 2022 07:22
@khavinshankar khavinshankar requested a review from a team as a code owner November 26, 2022 07:22
@netlify
Copy link

netlify bot commented Nov 26, 2022

Deploy Preview for care-egov-staging ready!

Name Link
🔨 Latest commit 78b08fd
🔍 Latest deploy log https://app.netlify.com/sites/care-egov-staging/deploys/6391619c427fa00008b1182a
😎 Deploy Preview https://deploy-preview-4121--care-egov-staging.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@vercel
Copy link

vercel bot commented Nov 26, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
care-storybook ✅ Ready (Inspect) Visit Preview Dec 8, 2022 at 4:05AM (UTC)

@khavinshankar khavinshankar reopened this Nov 27, 2022
@nihal467
Copy link
Member

nihal467 commented Dec 6, 2022

@gigincg
image

not able to see the profile name, marking it to team discussion required, for reviewing in call

@nihal467
Copy link
Member

nihal467 commented Dec 7, 2022

@khavinshankar @gigincg as per Eod, @skks1212 will be working on a solution

@nihal467
Copy link
Member

nihal467 commented Dec 7, 2022

@gigincg can you check the merge conflict

@netlify
Copy link

netlify bot commented Dec 8, 2022

Deploy Preview for care-net failed.

Name Link
🔨 Latest commit b4d58c5
🔍 Latest deploy log https://app.netlify.com/sites/care-net/deploys/63915a3f3882bd0008ae075a

@github-actions github-actions bot added the Deploy-Failed Deplyment is not showing preview label Dec 8, 2022
@sonarcloud
Copy link

sonarcloud bot commented Dec 8, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 2 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@khavinshankar khavinshankar added needs testing and removed work-in-progress Deploy-Failed Deplyment is not showing preview cypress failed pull request with cypress test failure labels Dec 8, 2022
@github-actions github-actions bot added the cypress failed pull request with cypress test failure label Dec 8, 2022
@khavinshankar
Copy link
Member Author

@nihal467 resolved the merge conflict, can you test it out again..

@nihal467
Copy link
Member

nihal467 commented Dec 8, 2022

LGTM

@gigincg gigincg merged commit f03c031 into develop Dec 8, 2022
@gigincg gigincg deleted the sidebar-scroll branch December 8, 2022 18:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cypress failed pull request with cypress test failure tested
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants