Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Migrate clsx to new classNames utility under the directory: src/Components/Common/** #4172

Merged
merged 2 commits into from
Dec 2, 2022
Merged

Migrate clsx to new classNames utility under the directory: src/Components/Common/** #4172

merged 2 commits into from
Dec 2, 2022

Conversation

rithviknishad
Copy link
Member

Proposed Changes

@coronasafe/care-fe-code-reviewers @coronasafe/code-reviewers

Merge Checklist

  • Add specs that demonstrate bug / test a new feature.
  • Update product documentation.
  • Ensure that UI text is kept in I18n files.
  • Prep screenshot or demo video for changelog entry, and attach it to issue.
  • Request for Peer Reviews
  • Completion of QA

@rithviknishad rithviknishad requested a review from a team December 1, 2022 15:00
@rithviknishad rithviknishad requested a review from a team as a code owner December 1, 2022 15:00
@vercel
Copy link

vercel bot commented Dec 1, 2022 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
care-storybook ✅ Ready (Inspect) Visit Preview Dec 1, 2022 at 3:01PM (UTC)

@netlify
Copy link

netlify bot commented Dec 1, 2022 •
edited
Loading

✅ Deploy Preview for care-egov-staging ready!

Name Link
🔨 Latest commit 72b2b26
🔍 Latest deploy log https://app.netlify.com/sites/care-egov-staging/deploys/6388c188add55c00087b9d67
😎 Deploy Preview https://deploy-preview-4172--care-egov-staging.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@sonarcloud
Copy link

sonarcloud bot commented Dec 1, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
1.5% 1.5% Duplication

@github-actions github-actions bot added the cypress failed pull request with cypress test failure label Dec 1, 2022
@rithviknishad rithviknishad added needs testing needs review and removed cypress failed pull request with cypress test failure labels Dec 2, 2022
@gigincg gigincg merged commit 27d4de3 into develop Dec 2, 2022
aeswibon pushed a commit to aeswibon/care_fe that referenced this pull request Dec 7, 2022
@rithviknishad @aeswibon
Migrate clsx to new classNames utility under the directory: `src/…
b10e76b 
…Components/Common/**` (ohcnetwork#4172)

* migrate

* migrate + prettier doing its thing
aeswibon pushed a commit to aeswibon/care_fe that referenced this pull request Dec 8, 2022
@rithviknishad @aeswibon
Migrate clsx to new classNames utility under the directory: `src/…
3ccc921 
…Components/Common/**` (ohcnetwork#4172)

* migrate

* migrate + prettier doing its thing
@rithviknishad rithviknishad deleted the classNames/src/Components/Common branch July 26, 2023 13:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bodhish bodhish Awaiting requested review from bodhish

Assignees
No one assigned
Labels
needs review needs testing
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Migrate clsx to new classNames utility under the directory: src/Components/Common/**
2 participants
@rithviknishad @gigincg