Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix minor alignment issue on patients page (filter badges) #4226

Merged
merged 24 commits into from
Jan 5, 2023
Merged

Fix minor alignment issue on patients page (filter badges) #4226

merged 24 commits into from
Jan 5, 2023

Conversation

siddnikh
Copy link
Contributor

@siddnikh siddnikh commented Dec 5, 2022 •
edited by aeswibon
Loading

Fixes #4225
Fixes #4344

@siddnikh
Merge pull request #1 from coronasafe/develop
d452a48 
Updating fork
@siddnikh
Merge branch 'coronasafe:develop' into develop
1195279
@siddnikh
Merge pull request #2 from coronasafe/develop
57b5d38 
Updating fork
@siddnikh
Merge pull request #3 from coronasafe/develop
7b8c8a6 
Update
@siddnikh
Merge pull request #4 from coronasafe/develop
4e93866 
update
@siddnikh
Merge pull request #5 from coronasafe/develop
bf0f583 
update
@siddnikh
Merge pull request #6 from coronasafe/develop
2afbb09 
update
@siddnikh
Merge pull request #7 from coronasafe/develop
1999a8c 
update
@siddnikh
Merge pull request #8 from coronasafe/develop
0115ac3 
update
@siddnikh
Merge pull request #9 from coronasafe/develop
5c38998 
update
@siddnikh
Merge pull request #10 from coronasafe/develop
50077ef 
Update
@siddnikh
Merge pull request #11 from coronasafe/develop
8a7a123 
update
@siddnikh
Merge pull request #12 from coronasafe/develop
ad6c76c 
update
@siddnikh
Merge pull request #13 from coronasafe/develop
9437221 
update
@siddnikh
Merge pull request #14 from coronasafe/develop
986ae40 
update
@siddnikh
Merge pull request #15 from coronasafe/develop
f33550f 
update
@siddnikh
Merge pull request #16 from coronasafe/develop
82dfd78 
update
@siddnikh
Fixed issue
aa4b6f2
@siddnikh siddnikh requested a review from a team December 5, 2022 17:09
@siddnikh siddnikh requested a review from a team as a code owner December 5, 2022 17:09
@netlify
Copy link

netlify bot commented Dec 5, 2022 •
edited
Loading

✅ Deploy Preview for care-egov-staging ready!

Name Link
🔨 Latest commit 1753e73
🔍 Latest deploy log https://app.netlify.com/sites/care-egov-staging/deploys/639cb0f8035c71000960bcc3
😎 Deploy Preview https://deploy-preview-4226--care-egov-staging.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@vercel
Copy link

vercel bot commented Dec 5, 2022 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
care-storybook ✅ Ready (Inspect) Visit Preview Dec 16, 2022 at 5:56PM (UTC)

rithviknishad
rithviknishad requested changes Dec 5, 2022
View reviewed changes
Copy link
Member

@rithviknishad rithviknishad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Replace with new FilterBadge component?

image

@github-actions
Copy link

Hi, This pr has been automatically marked as stale because it has not had any recent activity. It will be automatically closed if no further activity occurs for 7 more days. Thank you for your contributions.

@github-actions github-actions bot added the stale label Dec 13, 2022
@sonarcloud
Copy link

sonarcloud bot commented Dec 16, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 1 Code Smell

No Coverage information No Coverage information
0.0% 0.0% Duplication

@github-actions github-actions bot removed the stale label Dec 17, 2022
@rithviknishad rithviknishad mentioned this pull request Dec 18, 2022
Closed
@github-actions
Copy link

Hi, This pr has been automatically marked as stale because it has not had any recent activity. It will be automatically closed if no further activity occurs for 7 more days. Thank you for your contributions.

@github-actions github-actions bot added the stale label Dec 28, 2022
@nihal467
Copy link
Member

nihal467 commented Jan 3, 2023

@siddnikh can you merge the latest development branch and label it "Need testing"

@nihal467
Copy link
Member

nihal467 commented Jan 5, 2023

@siddnikh
image

the issue still persist

@khavinshankar
Copy link
Member

@rithviknishad can you rereview this one

@khavinshankar khavinshankar merged commit cc57a6c into ohcnetwork:develop Jan 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@khavinshankar khavinshankar khavinshankar approved these changes

@rithviknishad rithviknishad rithviknishad approved these changes

@mathew-alex mathew-alex Awaiting requested review from mathew-alex

Assignees
No one assigned
Labels
good to merge tested
Projects
None yet
Milestone
No milestone
4 participants
@siddnikh @nihal467 @khavinshankar @rithviknishad