Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix textarea borderline in consultation form #4276

Closed
wants to merge 3 commits into from
Closed

Fix textarea borderline in consultation form #4276

wants to merge 3 commits into from

Conversation

rithviknishad
Copy link
Member

@rithviknishad rithviknishad commented Dec 12, 2022 •
edited
Loading

Proposed Changes

image

image

image

@coronasafe/care-fe-code-reviewers @coronasafe/code-reviewers

Merge Checklist

  • Add specs that demonstrate bug / test a new feature.
  • Update product documentation.
  • Ensure that UI text is kept in I18n files.
  • Prep screenshot or demo video for changelog entry, and attach it to issue.
  • Request for Peer Reviews
  • Completion of QA

@netlify
Copy link

netlify bot commented Dec 12, 2022 •
edited
Loading

✅ Deploy Preview for care-egov-staging ready!

Name Link
🔨 Latest commit e788db2
🔍 Latest deploy log https://app.netlify.com/sites/care-egov-staging/deploys/6396b5b392d2760008232cd5
😎 Deploy Preview https://deploy-preview-4276--care-egov-staging.netlify.app/
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@vercel
Copy link

vercel bot commented Dec 12, 2022 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
care-storybook ✅ Ready (Inspect) Visit Preview Dec 12, 2022 at 5:03AM (UTC)

@sonarcloud
Copy link

sonarcloud bot commented Dec 12, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 8 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@rithviknishad rithviknishad marked this pull request as ready for review December 12, 2022 05:04
@rithviknishad rithviknishad requested a review from a team December 12, 2022 05:04
@rithviknishad rithviknishad requested a review from a team as a code owner December 12, 2022 05:04
@nihal467
Copy link
Member

@rithviknishad
image

was the Background color of the entire platform turned to grey intentionally?

@nihal467 nihal467 added the question Further information is requested label Dec 13, 2022
@rithviknishad
Copy link
Member Author

@nihal467 not intentional. however the color pallete of gray for the entire app was updated to respect color palette as per figma design.

Will update the background shade to a lighter shade in this PR itself.

@rithviknishad rithviknishad added work-in-progress and removed question Further information is requested needs testing labels Dec 13, 2022
@rithviknishad
Copy link
Member Author

Since the changes in this PR are no longer required to solve the problem, made a new PR #4309

@rithviknishad rithviknishad added wontfix This will not be worked on and removed work-in-progress labels Dec 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bodhish bodhish Awaiting requested review from bodhish

Assignees
No one assigned
Labels
redesign wontfix This will not be worked on
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Text box and borderline are different across the platform
2 participants
@rithviknishad @nihal467