Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Prevent updateQuery invocation if invalid phone number length #4470

Merged
merged 2 commits into from
Jan 6, 2023
Merged

Prevent updateQuery invocation if invalid phone number length #4470

merged 2 commits into from
Jan 6, 2023

Conversation

rithviknishad
Copy link
Member

@rithviknishad rithviknishad commented Jan 3, 2023 •
edited
Loading

Proposed Changes

@coronasafe/care-fe-code-reviewers @coronasafe/code-reviewers

Merge Checklist

  • Add specs that demonstrate bug / test a new feature.
  • Update product documentation.
  • Ensure that UI text is kept in I18n files.
  • Prep screenshot or demo video for changelog entry, and attach it to issue.
  • Request for Peer Reviews
  • Completion of QA

@rithviknishad rithviknishad requested a review from a team January 3, 2023 13:54
@rithviknishad rithviknishad requested a review from a team as a code owner January 3, 2023 13:54
@vercel
Copy link

vercel bot commented Jan 3, 2023 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
care-storybook ✅ Ready (Inspect) Visit Preview Jan 5, 2023 at 5:24AM (UTC)

@netlify
Copy link

netlify bot commented Jan 3, 2023 •
edited
Loading

✅ Deploy Preview for care-egov-staging ready!

Name Link
🔨 Latest commit 727647a
🔍 Latest deploy log https://app.netlify.com/sites/care-egov-staging/deploys/63b65e545fc46d0008dd9e5c
😎 Deploy Preview https://deploy-preview-4470--care-egov-staging.netlify.app/
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@rithviknishad rithviknishad mentioned this pull request Jan 5, 2023
Closed
6 tasks
@github-actions
Copy link

github-actions bot commented Jan 5, 2023

👋 Hi, @rithviknishad,
Conflicts have been detected against the base branch. Please rebase your branch against the base branch.

This message is automatically generated by prince-chrismc/label-merge-conflicts-action so don't hesitate to report issues/improvements there.

@github-actions github-actions bot added the merge conflict pull requests with merge conflict label Jan 5, 2023
@rithviknishad rithviknishad removed the merge conflict pull requests with merge conflict label Jan 5, 2023
@sonarcloud
Copy link

sonarcloud bot commented Jan 5, 2023

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 3 Code Smells

No Coverage information No Coverage information
9.8% 9.8% Duplication

@nihal467
Copy link
Member

nihal467 commented Jan 5, 2023

LGTM

@khavinshankar khavinshankar merged commit b536ad3 into ohcnetwork:develop Jan 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@khavinshankar khavinshankar khavinshankar approved these changes

@vigneshhari vigneshhari Awaiting requested review from vigneshhari

Assignees
No one assigned
Labels
tested
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Phone number search works only on exact match
3 participants
@rithviknishad @nihal467 @khavinshankar