Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Doctor Specialisation #4551

Merged
merged 15 commits into from
Jan 28, 2023
Merged

Doctor Specialisation #4551

merged 15 commits into from
Jan 28, 2023

Conversation

rithviknishad
Copy link
Member

@rithviknishad rithviknishad commented Jan 10, 2023 •
edited
Loading

Proposed Changes

@coronasafe/care-fe-code-reviewers @coronasafe/code-reviewers

Merge Checklist

  • Add specs that demonstrate bug / test a new feature.
  • Update product documentation.
  • Ensure that UI text is kept in I18n files.
  • Prep screenshot or demo video for changelog entry, and attach it to issue.
  • Request for Peer Reviews
  • Completion of QA

@rithviknishad rithviknishad requested a review from a team January 10, 2023 10:30
@rithviknishad rithviknishad requested a review from a team as a code owner January 10, 2023 10:30
@vercel
Copy link

vercel bot commented Jan 10, 2023 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated
care-storybook ✅ Ready (Inspect) Visit Preview 💬 Add your feedback Jan 27, 2023 at 4:16PM (UTC)

@netlify
Copy link

netlify bot commented Jan 10, 2023 •
edited
Loading

✅ Deploy Preview for care-egov-staging ready!

Name Link
🔨 Latest commit 1d24987
🔍 Latest deploy log https://app.netlify.com/sites/care-egov-staging/deploys/63d3f81d32c51c00081141ab
😎 Deploy Preview https://deploy-preview-4551--care-egov-staging.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@rithviknishad rithviknishad marked this pull request as draft January 10, 2023 10:31
@github-actions github-actions bot added cypress failed pull request with cypress test failure merge conflict pull requests with merge conflict labels Jan 10, 2023
@github-actions
Copy link

👋 Hi, @rithviknishad,
Conflicts have been detected against the base branch. Please rebase your branch against the base branch.

This message is automatically generated by prince-chrismc/label-merge-conflicts-action so don't hesitate to report issues/improvements there.

@rithviknishad rithviknishad removed merge conflict pull requests with merge conflict cypress failed pull request with cypress test failure labels Jan 16, 2023
@rithviknishad rithviknishad marked this pull request as ready for review January 16, 2023 15:07
@rithviknishad
Copy link
Member Author

@github-actions github-actions bot added the merge conflict pull requests with merge conflict label Jan 16, 2023
@github-actions
Copy link

👋 Hi, @rithviknishad,
Conflicts have been detected against the base branch. Please rebase your branch against the base branch.

This message is automatically generated by prince-chrismc/label-merge-conflicts-action so don't hesitate to report issues/improvements there.

@github-actions github-actions bot removed the merge conflict pull requests with merge conflict label Jan 18, 2023
@github-actions github-actions bot added the cypress failed pull request with cypress test failure label Jan 18, 2023
@nihal467
Copy link
Member

nihal467 commented Jan 24, 2023 •
edited
Loading

@rithviknishad
image

user id : test-Jan-999 , ( User type: Doctor ) , Password has been send of your slack

when we click, edit profile, after login in as a doctor, the page is crashing

@rithviknishad rithviknishad added needs testing and removed test failed cypress failed pull request with cypress test failure labels Jan 27, 2023
@github-actions github-actions bot added the cypress failed pull request with cypress test failure label Jan 27, 2023
@nihal467
Copy link
Member

@rithviknishad
image

even though the update form is getting submitted, the data is not getting updated

@sonarcloud
Copy link

sonarcloud bot commented Jan 27, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 2 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@rithviknishad
Copy link
Member Author

@nihal467 i've fixed it, could you checck now

@nihal467
Copy link
Member

LGTM

@khavinshankar khavinshankar merged commit 52f11b0 into develop Jan 28, 2023
@rithviknishad rithviknishad deleted the doctor-specialisation branch July 26, 2023 13:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@khavinshankar khavinshankar khavinshankar approved these changes

@mathew-alex mathew-alex Awaiting requested review from mathew-alex

Assignees
No one assigned
Labels
cypress failed pull request with cypress test failure needs testing
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Cross button is misaligned in the user creation page Doctors : Specialisation
3 participants
@rithviknishad @nihal467 @khavinshankar