Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Show 18 cards per page on Users page #4554

Merged
merged 1 commit into from
Jan 17, 2023
Merged

Show 18 cards per page on Users page #4554

merged 1 commit into from
Jan 17, 2023

Conversation

Pranshu1902
Copy link
Contributor

@Pranshu1902 Pranshu1902 commented Jan 10, 2023 •
edited
Loading

Fixes #4553
Display 18 cards per page instead of 15.
image

@Pranshu1902 Pranshu1902 requested a review from a team January 10, 2023 13:17
@Pranshu1902 Pranshu1902 requested a review from a team as a code owner January 10, 2023 13:17
@vercel
Copy link

vercel bot commented Jan 10, 2023 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
care-storybook ✅ Ready (Inspect) Visit Preview Jan 10, 2023 at 1:19PM (UTC)

@sonarcloud
Copy link

sonarcloud bot commented Jan 10, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@netlify
Copy link

netlify bot commented Jan 10, 2023 •
edited
Loading

✅ Deploy Preview for care-egov-staging ready!

Name Link
🔨 Latest commit fa4c202
🔍 Latest deploy log https://app.netlify.com/sites/care-egov-staging/deploys/63bd6550a4337b00096f064d
😎 Deploy Preview https://deploy-preview-4554--care-egov-staging.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@nihal467
Copy link
Member

@Pranshu1902 @khavinshankar the current staging is having 18 cards, can you do check it

@Pranshu1902
Copy link
Contributor Author

Pranshu1902 commented Jan 16, 2023 •
edited
Loading

@nihal467 It is 15 only
https://github.com/coronasafe/care_fe/blob/develop/src/Components/Users/ManageUsers.tsx#L47
I am talking about the users page only

@nihal467
Copy link
Member

LGTM

@khavinshankar khavinshankar merged commit 0c48ba0 into ohcnetwork:develop Jan 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@khavinshankar khavinshankar khavinshankar approved these changes

@gigincg gigincg Awaiting requested review from gigincg

Assignees
No one assigned
Labels
tested
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

One card is missing on Users page in 2 column view
3 participants
@Pranshu1902 @nihal467 @khavinshankar