Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Made mandatory validation in ONVIF camera and HL7 monitor asset page and migrated all possible input to textformfield #4608

Closed
wants to merge 6 commits into from
Closed

Made mandatory validation in ONVIF camera and HL7 monitor asset page and migrated all possible input to textformfield #4608

wants to merge 6 commits into from

Conversation

patelaryan7751
Copy link
Contributor

Proposed Changes

@coronasafe/care-fe-code-reviewers @coronasafe/code-reviewers

Merge Checklist

  • Add specs that demonstrate bug / test a new feature.
  • Update product documentation.
  • Ensure that UI text is kept in I18n files.
  • Prep screenshot or demo video for changelog entry, and attach it to issue.
  • Request for Peer Reviews
  • Completion of QA

@patelaryan7751
Made mandatory validation in ONVIF camera and HL7 monitor asset page …
3bdf778 
…and migrated all possible input to textformfield
@patelaryan7751 patelaryan7751 requested a review from a team January 15, 2023 20:45
@patelaryan7751 patelaryan7751 requested a review from a team as a code owner January 15, 2023 20:45
@vercel
Copy link

vercel bot commented Jan 15, 2023 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated
care-storybook ✅ Ready (Inspect) Visit Preview 💬 Add your feedback Feb 3, 2023 at 2:53AM (UTC)

@netlify
Copy link

netlify bot commented Jan 15, 2023 •
edited
Loading

✅ Deploy Preview for care-egov-staging ready!

Name Link
🔨 Latest commit 020bd5e
🔍 Latest deploy log https://app.netlify.com/sites/care-egov-staging/deploys/63dc7698626d9a0008b7ac06
😎 Deploy Preview https://deploy-preview-4608--care-egov-staging.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@github-actions github-actions bot added the merge conflict pull requests with merge conflict label Jan 16, 2023
@github-actions
Copy link

👋 Hi, @patelaryan7751,
Conflicts have been detected against the base branch. Please rebase your branch against the base branch.

This message is automatically generated by prince-chrismc/label-merge-conflicts-action so don't hesitate to report issues/improvements there.

@netlify
Copy link

netlify bot commented Jan 16, 2023

❌ Deploy Preview for care-net failed.

Name Link
🔨 Latest commit d7daf46
🔍 Latest deploy log https://app.netlify.com/sites/care-net/deploys/63c56594ffd6d200086205df

@github-actions github-actions bot removed the merge conflict pull requests with merge conflict label Jan 16, 2023
@nihal467
Copy link
Member

nihal467 commented Jan 17, 2023 •
edited
Loading

@patelaryan7751
image

  • the deployment preview is not working for this PR, merge the latest development branch
  • the middleware inside the asset configuration page will be removed eventually, so don't add validation for that column

@github-actions github-actions bot added the merge conflict pull requests with merge conflict label Jan 25, 2023
@github-actions
Copy link

👋 Hi, @patelaryan7751,
Conflicts have been detected against the base branch. Please rebase your branch against the base branch.

This message is automatically generated by prince-chrismc/label-merge-conflicts-action so don't hesitate to report issues/improvements there.

@patelaryan7751 patelaryan7751 removed the merge conflict pull requests with merge conflict label Feb 3, 2023
@sonarcloud
Copy link

sonarcloud bot commented Feb 3, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 2 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@github-actions github-actions bot added the merge conflict pull requests with merge conflict label Feb 3, 2023
@github-actions
Copy link

github-actions bot commented Feb 3, 2023

👋 Hi, @patelaryan7751,
Conflicts have been detected against the base branch. Please rebase your branch against the base branch.

This message is automatically generated by prince-chrismc/label-merge-conflicts-action so don't hesitate to report issues/improvements there.

@patelaryan7751
Copy link
Contributor Author

openning a new PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mathew-alex mathew-alex Awaiting requested review from mathew-alex

Assignees
No one assigned
Labels
merge conflict pull requests with merge conflict work-in-progress
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Make mandatory validation in ONVIF camera and HL7 monitor asset page
2 participants
@patelaryan7751 @nihal467