Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Made the sidebar tooltip visible #4609

Merged
merged 8 commits into from
Feb 21, 2023
Merged

Made the sidebar tooltip visible #4609

merged 8 commits into from
Feb 21, 2023

Conversation

patelaryan7751
Copy link
Contributor

Proposed Changes

@coronasafe/care-fe-code-reviewers @coronasafe/code-reviewers

Merge Checklist

  • Add specs that demonstrate bug / test a new feature.
  • Update product documentation.
  • Ensure that UI text is kept in I18n files.
  • Prep screenshot or demo video for changelog entry, and attach it to issue.
  • Request for Peer Reviews
  • Completion of QA

@patelaryan7751 patelaryan7751 requested a review from a team January 15, 2023 21:25
@patelaryan7751 patelaryan7751 requested a review from a team as a code owner January 15, 2023 21:25
@vercel
Copy link

vercel bot commented Jan 15, 2023 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated
care-storybook ✅ Ready (Inspect) Visit Preview 💬 Add your feedback Feb 16, 2023 at 3:19AM (UTC)

@netlify
Copy link

netlify bot commented Jan 15, 2023 •
edited
Loading

✅ Deploy Preview for care-egov-staging ready!

Name Link
🔨 Latest commit b322105
🔍 Latest deploy log https://app.netlify.com/sites/care-egov-staging/deploys/63ed9ffd966822000747da4d
😎 Deploy Preview https://deploy-preview-4609--care-egov-staging.netlify.app/
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@nihal467
Copy link
Member

nihal467 commented Jan 17, 2023 •
edited
Loading

@patelaryan7751
image

I am unable to see the profile icon and other details, in 14 inch screen

@patelaryan7751
Copy link
Contributor Author

patelaryan7751 commented Jan 17, 2023 •
edited
Loading

Hey @nihal467 the tooltip will be visible when the navbar is collapsed please collapse it and check . This issue is only related to make the tooltip visible if you want i can work on the profile icon issue or shall we make a new issue and work on it .

@nihal467
Copy link
Member

nihal467 commented Jan 17, 2023 •
edited
Loading

@patelaryan7751
image

I am able to see the profile details and everything of sidebar in our current staging, but in your PR, the sidebar full data are not visible for example user name

@patelaryan7751
Copy link
Contributor Author

Hey @nihal467 i have fixed the bug
image

@nihal467
Copy link
Member

LGTM

khavinshankar
khavinshankar approved these changes Jan 23, 2023
View reviewed changes
Copy link
Member

@khavinshankar khavinshankar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks Good, @patelaryan7751 can you just remove the console logs

@github-actions github-actions bot added the merge conflict pull requests with merge conflict label Jan 23, 2023
@github-actions
Copy link

👋 Hi, @patelaryan7751,
Conflicts have been detected against the base branch. Please rebase your branch against the base branch.

This message is automatically generated by prince-chrismc/label-merge-conflicts-action so don't hesitate to report issues/improvements there.

@patelaryan7751 patelaryan7751 removed the merge conflict pull requests with merge conflict label Jan 23, 2023
@github-actions github-actions bot added the merge conflict pull requests with merge conflict label Jan 24, 2023
@github-actions
Copy link

👋 Hi, @patelaryan7751,
Conflicts have been detected against the base branch. Please rebase your branch against the base branch.

This message is automatically generated by prince-chrismc/label-merge-conflicts-action so don't hesitate to report issues/improvements there.

@patelaryan7751 patelaryan7751 removed the merge conflict pull requests with merge conflict label Feb 3, 2023
@sonarcloud
Copy link

sonarcloud bot commented Feb 16, 2023

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
7.1% 7.1% Duplication

@patelaryan7751
Copy link
Contributor Author

Hey @khavinshankar i have removed all consolelogs

@khavinshankar khavinshankar merged commit bc859a9 into ohcnetwork:develop Feb 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@khavinshankar khavinshankar khavinshankar approved these changes

@bodhish bodhish Awaiting requested review from bodhish

Assignees
No one assigned
Labels
tested
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Sidebar tooltip not visible
3 participants
@patelaryan7751 @nihal467 @khavinshankar