Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CareUI: bg-white for secondary variant ButtonV2 #4626

Merged
merged 2 commits into from
Jan 24, 2023
Merged

CareUI: bg-white for secondary variant ButtonV2 #4626

merged 2 commits into from
Jan 24, 2023

Conversation

rithviknishad
Copy link
Member

Proposed Changes

image

image

@coronasafe/care-fe-code-reviewers @coronasafe/code-reviewers

Merge Checklist

  • Add specs that demonstrate bug / test a new feature.
  • Update product documentation.
  • Ensure that UI text is kept in I18n files.
  • Prep screenshot or demo video for changelog entry, and attach it to issue.
  • Request for Peer Reviews
  • Completion of QA

@rithviknishad rithviknishad requested a review from a team January 18, 2023 06:39
@rithviknishad rithviknishad requested a review from a team as a code owner January 18, 2023 06:39
@vercel
Copy link

vercel bot commented Jan 18, 2023 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated
care-storybook ✅ Ready (Inspect) Visit Preview 💬 Add your feedback Jan 18, 2023 at 6:46AM (UTC)

@netlify
Copy link

netlify bot commented Jan 18, 2023 •
edited
Loading

✅ Deploy Preview for care-egov-staging ready!

Name Link
🔨 Latest commit b25411e
🔍 Latest deploy log https://app.netlify.com/sites/care-egov-staging/deploys/63c7950c96bb690008819c2f
😎 Deploy Preview https://deploy-preview-4626--care-egov-staging.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@sonarcloud
Copy link

sonarcloud bot commented Jan 18, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@github-actions github-actions bot added the cypress failed pull request with cypress test failure label Jan 18, 2023
@nihal467
Copy link
Member

LGTM @rithviknishad check cypres

@khavinshankar khavinshankar merged commit a5ea73e into develop Jan 24, 2023
@rithviknishad rithviknishad deleted the careui/buttonv2/secondary-bg-white branch July 26, 2023 13:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@khavinshankar khavinshankar khavinshankar approved these changes

@vigneshhari vigneshhari Awaiting requested review from vigneshhari

Assignees
No one assigned
Labels
cypress failed pull request with cypress test failure tested
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Make background of secondary variant ButtonV2 to white
3 participants
@rithviknishad @nihal467 @khavinshankar