Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Localizations for texts in Hub #4691

Merged
merged 5 commits into from
Feb 3, 2023
Merged

Localizations for texts in Hub #4691

merged 5 commits into from
Feb 3, 2023

Conversation

Ashesh3
Copy link
Member

@Ashesh3 Ashesh3 commented Jan 29, 2023

Resolves #4481

@coronasafe/care-fe-code-reviewers @coronasafe/code-reviewers

@Ashesh3 Ashesh3 requested a review from a team January 29, 2023 08:22
@Ashesh3 Ashesh3 requested a review from a team as a code owner January 29, 2023 08:22
@Ashesh3 Ashesh3 requested a review from bodhish January 29, 2023 08:22
@vercel
Copy link

vercel bot commented Jan 29, 2023 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated
care-storybook ✅ Ready (Inspect) Visit Preview 💬 Add your feedback Feb 3, 2023 at 3:11PM (UTC)

@netlify
Copy link

netlify bot commented Jan 29, 2023 •
edited
Loading

✅ Deploy Preview for care-egov-staging ready!

Name Link
🔨 Latest commit 1dacf98
🔍 Latest deploy log https://app.netlify.com/sites/care-egov-staging/deploys/63dd239e533baa000860e974
😎 Deploy Preview https://deploy-preview-4691--care-egov-staging.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@github-actions github-actions bot added the merge conflict pull requests with merge conflict label Jan 30, 2023
@github-actions
Copy link

👋 Hi, @Ashesh3,
Conflicts have been detected against the base branch. Please rebase your branch against the base branch.

This message is automatically generated by prince-chrismc/label-merge-conflicts-action so don't hesitate to report issues/improvements there.

@Ashesh3 Ashesh3 removed the merge conflict pull requests with merge conflict label Jan 30, 2023
@nihal467
Copy link
Member

@khavinshankar can you review it

@github-actions github-actions bot added the merge conflict pull requests with merge conflict label Feb 3, 2023
@github-actions
Copy link

github-actions bot commented Feb 3, 2023

👋 Hi, @Ashesh3,
Conflicts have been detected against the base branch. Please rebase your branch against the base branch.

This message is automatically generated by prince-chrismc/label-merge-conflicts-action so don't hesitate to report issues/improvements there.

@Ashesh3 Ashesh3 removed the merge conflict pull requests with merge conflict label Feb 3, 2023
@netlify
Copy link

netlify bot commented Feb 3, 2023

❌ Deploy Preview for care-net failed.

Name Link
🔨 Latest commit caeb2c3
🔍 Latest deploy log https://app.netlify.com/sites/care-net/deploys/63dcbaa3fbad130008978cf6

@github-actions github-actions bot added the Deploy-Failed Deplyment is not showing preview label Feb 3, 2023
@Ashesh3 Ashesh3 removed the Deploy-Failed Deplyment is not showing preview label Feb 3, 2023
@github-actions github-actions bot added the merge conflict pull requests with merge conflict label Feb 3, 2023
@github-actions
Copy link

github-actions bot commented Feb 3, 2023

👋 Hi, @Ashesh3,
Conflicts have been detected against the base branch. Please rebase your branch against the base branch.

This message is automatically generated by prince-chrismc/label-merge-conflicts-action so don't hesitate to report issues/improvements there.

@sonarcloud
Copy link

sonarcloud bot commented Feb 3, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
2.9% 2.9% Duplication

@github-actions github-actions bot removed the merge conflict pull requests with merge conflict label Feb 3, 2023
@khavinshankar khavinshankar merged commit cc7da25 into ohcnetwork:develop Feb 3, 2023
rabilrbl pushed a commit that referenced this pull request Feb 6, 2023
@Ashesh3 @khavinshankar @rabilrbl
Localizations for texts in Hub (#4691)
96a8fed 
* Localizations for texts in Hub

* Fix build failing

---------

Co-authored-by: Khavin Shankar <khavinshankar@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@khavinshankar khavinshankar khavinshankar approved these changes

@bodhish bodhish Awaiting requested review from bodhish

Assignees
No one assigned
Labels
needs testing
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Localizations for texts in Hub
3 participants
@Ashesh3 @nihal467 @khavinshankar