Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed bed select going under card in CameraConfigure #4704

Merged
merged 1 commit into from
Feb 3, 2023
Merged

Fixed bed select going under card in CameraConfigure #4704

merged 1 commit into from
Feb 3, 2023

Conversation

khavinshankar
Copy link
Member

Proposed Changes

@coronasafe/care-fe-code-reviewers @coronasafe/code-reviewers

Merge Checklist

  • Add specs that demonstrate bug / test a new feature.
  • Update product documentation.
  • Ensure that UI text is kept in I18n files.
  • Prep screenshot or demo video for changelog entry, and attach it to issue.
  • Request for Peer Reviews
  • Completion of QA

@khavinshankar khavinshankar requested a review from a team January 30, 2023 17:46
@khavinshankar khavinshankar requested a review from a team as a code owner January 30, 2023 17:46
@vercel
Copy link

vercel bot commented Jan 30, 2023 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated
care-storybook ✅ Ready (Inspect) Visit Preview 💬 Add your feedback Jan 30, 2023 at 5:48PM (UTC)

@netlify
Copy link

netlify bot commented Jan 30, 2023 •
edited
Loading

✅ Deploy Preview for care-egov-staging ready!

Name Link
🔨 Latest commit bfac4d8
🔍 Latest deploy log https://app.netlify.com/sites/care-egov-staging/deploys/63d80285f0ccc00007b01f55
😎 Deploy Preview https://deploy-preview-4704--care-egov-staging.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@sonarcloud
Copy link

sonarcloud bot commented Jan 30, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@github-actions github-actions bot added the cypress failed pull request with cypress test failure label Jan 30, 2023
@nihal467
Copy link
Member

LGTM

@gigincg gigincg merged commit 5ec7929 into develop Feb 3, 2023
@gigincg gigincg deleted the fix#4640 branch February 3, 2023 07:36
rabilrbl pushed a commit that referenced this pull request Feb 6, 2023
@khavinshankar @rabilrbl
fix (CameraConfigure): fixed bed select going under card (#4704)
655d7a4
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mathew-alex mathew-alex Awaiting requested review from mathew-alex

Assignees
No one assigned
Labels
cypress failed pull request with cypress test failure tested urgent
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

the preset dropdown is overlapping with camera feed in asset configuration
3 participants
@khavinshankar @nihal467 @gigincg