Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed data type mismatch issue in medicine #4725

Merged
merged 1 commit into from
Feb 3, 2023
Merged

Fixed data type mismatch issue in medicine #4725

merged 1 commit into from
Feb 3, 2023

Conversation

khavinshankar
Copy link
Member

Proposed Changes

  • Fixed data type mismatch issue in medicine
  • should fix the blank page problem when we go to the medicine tab in old consultations

@coronasafe/care-fe-code-reviewers @coronasafe/code-reviewers

Merge Checklist

  • Add specs that demonstrate bug / test a new feature.
  • Update product documentation.
  • Ensure that UI text is kept in I18n files.
  • Prep screenshot or demo video for changelog entry, and attach it to issue.
  • Request for Peer Reviews
  • Completion of QA

@khavinshankar khavinshankar requested a review from a team February 1, 2023 11:39
@khavinshankar khavinshankar requested a review from a team as a code owner February 1, 2023 11:39
@vercel
Copy link

vercel bot commented Feb 1, 2023 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated
care-storybook ✅ Ready (Inspect) Visit Preview 💬 Add your feedback Feb 1, 2023 at 11:39AM (UTC)

@netlify
Copy link

netlify bot commented Feb 1, 2023 •
edited
Loading

✅ Deploy Preview for care-egov-staging ready!

Name Link
🔨 Latest commit cf53872
🔍 Latest deploy log https://app.netlify.com/sites/care-egov-staging/deploys/63da4f7218b9a30009c86803
😎 Deploy Preview https://deploy-preview-4725--care-egov-staging.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@sonarcloud
Copy link

sonarcloud bot commented Feb 1, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@github-actions github-actions bot added the cypress failed pull request with cypress test failure label Feb 1, 2023
@nihal467
Copy link
Member

nihal467 commented Feb 1, 2023

LGTM

@nihal467 nihal467 added tested and removed urgent labels Feb 1, 2023
@Pranshu1902 Pranshu1902 mentioned this pull request Feb 2, 2023
Closed
@Pranshu1902
Copy link
Contributor

Fixes #4732

@gigincg gigincg merged commit 8c44be7 into develop Feb 3, 2023
@Pranshu1902 Pranshu1902 mentioned this pull request Feb 3, 2023
Closed
rabilrbl pushed a commit that referenced this pull request Feb 6, 2023
@khavinshankar @rabilrbl
Fixed data type mismatch issue in medicine (#4725)
60bdc6c
@sainak sainak deleted the fix#medice-data-issue branch February 21, 2024 15:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gigincg gigincg gigincg approved these changes

@vigneshhari vigneshhari Awaiting requested review from vigneshhari

Assignees
No one assigned
Labels
cypress failed pull request with cypress test failure tested
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@khavinshankar @nihal467 @Pranshu1902 @gigincg