-
Notifications
You must be signed in to change notification settings - Fork 437
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Change error statement colour from black to red in patient creation form #4882
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
✅ Deploy Preview for care-egov-staging ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
Kudos, SonarCloud Quality Gate passed! 0 Bugs No Coverage information |
@@ -537,7 +549,9 @@ export const PatientRegister = (props: PatientRegisterProps) => { | |||
state.form.nationality === "India" && | |||
!Number(state.form[field]) | |||
) { | |||
errors[field] = "Please select ward"; | |||
errors[field] = ( | |||
<span className="text-red-500">Please select ward</span> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@siva-balan wouldn't the FormField component apply the colors automatically?
You can make use of SelectFormField
for gender select.
<span className="text-red-500">Please select ward</span> | |
<span className="text-red-500">Please select ward</span> |
<span className="text-red-500">Please select ward</span> | |
Please select ward |
@rithviknishad I am unable to use SelectFormField for the States and districts. I am getting some errors, can you help with that... I am able to use that for gender but not for others. |
Hey @siva-balan 👋🏼 sure, happy to help you out. Have a look at Let me know if you are still facing issues after looking at this. |
@rithviknishad I already had a look at that, and I tried to implement it similarly but I am not able to click the states in the drop-down. Could you take a look at this? Tell me if there's anything I need to change.. Thanks for the help. |
@siva-balan I'm guessing that you are using |
@siva-balan once there are no more legacy input fields that's using |
@rithviknishad Thanks for the fix, I was able to implement them, but the drop-down options are not fully visible due to using the select form field. They are being hidden by the below component. Any idea on how to solve that? |
@siva-balan this is probably because the parent container has |
@siva-balan the Material UI's You may remove these if so: |
Proposed Changes
Fixes Change error statement colour from black to red in patient creation form #4867
Changes:
Changed text field to text form field and added red color to errors in the select field.
@coronasafe/care-fe-code-reviewers @coronasafe/code-reviewers
Merge Checklist