Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Migrate Asset Class Icons to use Care Icons only #5031

Merged
merged 5 commits into from
Mar 8, 2023
Merged

Migrate Asset Class Icons to use Care Icons only #5031

merged 5 commits into from
Mar 8, 2023

Conversation

rithviknishad
Copy link
Member

@rithviknishad rithviknishad commented Mar 2, 2023 •
edited
Loading

Proposed Changes

image

@coronasafe/care-fe-code-reviewers @coronasafe/code-reviewers

Merge Checklist

  • Add specs that demonstrate bug / test a new feature.
  • Update product documentation.
  • Ensure that UI text is kept in I18n files.
  • Prep screenshot or demo video for changelog entry, and attach it to issue.
  • Request for Peer Reviews
  • Completion of QA

@rithviknishad rithviknishad requested a review from a team March 2, 2023 08:11
@rithviknishad rithviknishad requested a review from a team as a code owner March 2, 2023 08:11
@vercel
Copy link

vercel bot commented Mar 2, 2023 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated
care-storybook ✅ Ready (Inspect) Visit Preview 💬 Add your feedback Mar 7, 2023 at 11:52AM (UTC)

@netlify
Copy link

netlify bot commented Mar 2, 2023 •
edited
Loading

✅ Deploy Preview for care-egov-staging ready!

Name Link
🔨 Latest commit 3c7822c
🔍 Latest deploy log https://app.netlify.com/sites/care-egov-staging/deploys/6407251cfcc3c500080fea7e
😎 Deploy Preview https://deploy-preview-5031--care-egov-staging.netlify.app/
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@nihal467
Copy link
Member

nihal467 commented Mar 5, 2023

@rithviknishad

image

  • increase the size of the icon, doesn't look good
  • the icon for representing monitor doesn't feel good, can you find an alternative, and put it up in Mondays EOD

@github-actions github-actions bot added the merge conflict pull requests with merge conflict label Mar 6, 2023
@github-actions
Copy link

github-actions bot commented Mar 6, 2023

👋 Hi, @rithviknishad,
Conflicts have been detected against the base branch. Please rebase your branch against the base branch.

This message is automatically generated by prince-chrismc/label-merge-conflicts-action so don't hesitate to report issues/improvements there.

@rithviknishad rithviknishad removed work-in-progress merge conflict pull requests with merge conflict labels Mar 7, 2023
@sonarcloud
Copy link

sonarcloud bot commented Mar 7, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
2.2% 2.2% Duplication

@nihal467
Copy link
Member

nihal467 commented Mar 8, 2023

LGTM

@khavinshankar khavinshankar merged commit cdfeff6 into ohcnetwork:develop Mar 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@khavinshankar khavinshankar khavinshankar approved these changes

@mathew-alex mathew-alex Awaiting requested review from mathew-alex

Assignees
No one assigned
Labels
tested
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Icons for Asset Class partially uses care icons and font-awesome icons
3 participants
@rithviknishad @nihal467 @khavinshankar