-
Notifications
You must be signed in to change notification settings - Fork 437
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
remove mui CircularProgress #5134
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
✅ Deploy Preview for care-egov-staging ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
fix issue #4996 |
Kudos, SonarCloud Quality Gate passed! 0 Bugs No Coverage information |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- you may make use of new FormField components instead for the entire list filter. The list filter seems to be still using legacy components.
- the
SelectField
fromHelperInputFields
indirectly uses MUI. You may make use ofSelectFormField
instead.
@@ -11,7 +11,6 @@ import { | |||
import moment from "moment"; | |||
import { getAnyFacility, getUserList } from "../../Redux/actions"; | |||
import { useDispatch } from "react-redux"; | |||
import { CircularProgress } from "@material-ui/core"; | |||
import { SHIFTING_CHOICES } from "../../Common/constants"; | |||
import { DateRangePicker, getDate } from "../Common/DateRangePicker"; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ayushjnv1 this DatePicker indirectly uses Material UI components. You may make use of DateRangeFormField
as a replacement which is the new custom components.
import { DateRangePicker, getDate } from "../Common/DateRangePicker"; | |
import { DateRangePicker, getDate } from "../Common/DateRangePicker"; |
Hi, This pr has been automatically marked as stale because it has not had any recent activity. It will be automatically closed if no further activity occurs for 7 more days. Thank you for your contributions. |
👋 Hi, @ayushjnv1, This message is automatically generated by prince-chrismc/label-merge-conflicts-action so don't hesitate to report issues/improvements there. |
Hi, This pr has been automatically marked as stale because it has not had any recent activity. It will be automatically closed if no further activity occurs for 7 more days. Thank you for your contributions. |
Hi, @gigincg, @nihal467, @khavinshankar, @mathew-alex, This pr has been automatically closed because it has not had any recent activity. Thank you for your contributions. Feel free to repopen the pr. |
Proposed Changes
src/Components/Shifting/ListFilter.tsx
: #4996@coronasafe/care-fe-code-reviewers @coronasafe/code-reviewers
Merge Checklist