Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove mui CircularProgress #5134

Closed
wants to merge 1 commit into from
Closed

Conversation

ayushjnv1
Copy link
Contributor

@ayushjnv1 ayushjnv1 commented Mar 20, 2023

Proposed Changes

@coronasafe/care-fe-code-reviewers @coronasafe/code-reviewers

Merge Checklist

  • Add specs that demonstrate bug / test a new feature.
  • Update product documentation.
  • Ensure that UI text is kept in I18n files.
  • Prep screenshot or demo video for changelog entry, and attach it to issue.
  • Request for Peer Reviews
  • Completion of QA

@ayushjnv1 ayushjnv1 requested a review from a team March 20, 2023 18:35
@ayushjnv1 ayushjnv1 requested a review from a team as a code owner March 20, 2023 18:35
@ayushjnv1 ayushjnv1 requested a review from bodhish March 20, 2023 18:35
@vercel
Copy link

vercel bot commented Mar 20, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated
care-storybook ✅ Ready (Inspect) Visit Preview 💬 Add your feedback Mar 20, 2023 at 6:37PM (UTC)

@netlify
Copy link

netlify bot commented Mar 20, 2023

Deploy Preview for care-egov-staging ready!

Name Link
🔨 Latest commit 1224a92
🔍 Latest deploy log https://app.netlify.com/sites/care-egov-staging/deploys/6418a75a85f3e20008d84058
😎 Deploy Preview https://deploy-preview-5134--care-egov-staging.netlify.app/
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@ayushjnv1
Copy link
Contributor Author

fix issue #4996

@sonarcloud
Copy link

sonarcloud bot commented Mar 20, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
2.1% 2.1% Duplication

Copy link
Member

@rithviknishad rithviknishad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ayushjnv1

  • you may make use of new FormField components instead for the entire list filter. The list filter seems to be still using legacy components.
  • the SelectField from HelperInputFields indirectly uses MUI. You may make use of SelectFormField instead.

image

@@ -11,7 +11,6 @@ import {
import moment from "moment";
import { getAnyFacility, getUserList } from "../../Redux/actions";
import { useDispatch } from "react-redux";
import { CircularProgress } from "@material-ui/core";
import { SHIFTING_CHOICES } from "../../Common/constants";
import { DateRangePicker, getDate } from "../Common/DateRangePicker";
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ayushjnv1 this DatePicker indirectly uses Material UI components. You may make use of DateRangeFormField as a replacement which is the new custom components.

Suggested change
import { DateRangePicker, getDate } from "../Common/DateRangePicker";
import { DateRangePicker, getDate } from "../Common/DateRangePicker";

@github-actions
Copy link

Hi, This pr has been automatically marked as stale because it has not had any recent activity. It will be automatically closed if no further activity occurs for 7 more days. Thank you for your contributions.

@github-actions github-actions bot added the stale label Mar 29, 2023
@github-actions github-actions bot added the merge conflict pull requests with merge conflict label Apr 5, 2023
@github-actions
Copy link

github-actions bot commented Apr 5, 2023

👋 Hi, @ayushjnv1,
Conflicts have been detected against the base branch. Please rebase your branch against the base branch.


This message is automatically generated by prince-chrismc/label-merge-conflicts-action so don't hesitate to report issues/improvements there.

@github-actions github-actions bot removed the stale label Apr 6, 2023
@github-actions
Copy link

Hi, This pr has been automatically marked as stale because it has not had any recent activity. It will be automatically closed if no further activity occurs for 7 more days. Thank you for your contributions.

@github-actions github-actions bot added the stale label Apr 13, 2023
@github-actions
Copy link

Hi, @gigincg, @nihal467, @khavinshankar, @mathew-alex, This pr has been automatically closed because it has not had any recent activity. Thank you for your contributions. Feel free to repopen the pr.

@github-actions github-actions bot closed this Apr 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changes required merge conflict pull requests with merge conflict stale
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Replace Material UI components in src/Components/Shifting/ListFilter.tsx:
2 participants