Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remove MUI button or CircularProgress #5135

Merged
merged 2 commits into from
Mar 21, 2023
Merged

remove MUI button or CircularProgress #5135

merged 2 commits into from
Mar 21, 2023

Conversation

ayushjnv1
Copy link
Contributor

@ayushjnv1 ayushjnv1 commented Mar 20, 2023 •
edited by rithviknishad
Loading

Proposed Changes

@coronasafe/care-fe-code-reviewers @coronasafe/code-reviewers

Merge Checklist

  • Add specs that demonstrate bug / test a new feature.
  • Update product documentation.
  • Ensure that UI text is kept in I18n files.
  • Prep screenshot or demo video for changelog entry, and attach it to issue.
  • Request for Peer Reviews
  • Completion of QA

@ayushjnv1 ayushjnv1 requested a review from a team March 20, 2023 19:16
@ayushjnv1 ayushjnv1 requested a review from a team as a code owner March 20, 2023 19:16
@vercel
Copy link

vercel bot commented Mar 20, 2023 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated
care-storybook ✅ Ready (Inspect) Visit Preview 💬 Add your feedback Mar 21, 2023 at 3:21AM (UTC)

@netlify
Copy link

netlify bot commented Mar 20, 2023 •
edited
Loading

✅ Deploy Preview for care-egov-staging ready!

Name Link
🔨 Latest commit 8fab06e
🔍 Latest deploy log https://app.netlify.com/sites/care-egov-staging/deploys/641922072f109e000877c10a
😎 Deploy Preview https://deploy-preview-5135--care-egov-staging.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@ayushjnv1
Copy link
Contributor Author

ayushjnv1 commented Mar 20, 2023 •
edited
Loading

fix #4995

@sonarcloud
Copy link

sonarcloud bot commented Mar 21, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
2.1% 2.1% Duplication

@nihal467
Copy link
Member

LGTM

@khavinshankar khavinshankar merged commit ad0ed91 into ohcnetwork:develop Mar 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@khavinshankar khavinshankar khavinshankar approved these changes

@rithviknishad rithviknishad rithviknishad approved these changes

@mathew-alex mathew-alex Awaiting requested review from mathew-alex

Assignees
No one assigned
Labels
tested
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Replace Material UI components in src/Components/Shifting/CommentsSection.tsx:
4 participants
@ayushjnv1 @nihal467 @rithviknishad @khavinshankar