Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix location select on asset creation page #5155

Merged
merged 2 commits into from
Mar 23, 2023
Merged

Fix location select on asset creation page #5155

merged 2 commits into from
Mar 23, 2023

Conversation

Ashesh3
Copy link
Member

@Ashesh3 Ashesh3 commented Mar 23, 2023

Fixes #5151

@coronasafe/care-fe-code-reviewers @coronasafe/code-reviewers

@Ashesh3 Ashesh3 added needs testing P1 breaking issue or vital feature labels Mar 23, 2023
@vercel
Copy link

vercel bot commented Mar 23, 2023 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated
care-storybook ✅ Ready (Inspect) Visit Preview 💬 Add your feedback Mar 23, 2023 at 10:52AM (UTC)

@Ashesh3 Ashesh3 marked this pull request as ready for review March 23, 2023 08:53
@netlify
Copy link

netlify bot commented Mar 23, 2023 •
edited
Loading

✅ Deploy Preview for care-egov-staging ready!

Name Link
🔨 Latest commit 26a0c90
🔍 Latest deploy log https://app.netlify.com/sites/care-egov-staging/deploys/641c2ef3979c5e0008a12ed5
😎 Deploy Preview https://deploy-preview-5155--care-egov-staging.netlify.app/
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@Ashesh3 Ashesh3 requested a review from a team March 23, 2023 08:53
@Ashesh3 Ashesh3 requested a review from a team as a code owner March 23, 2023 08:53
@nihal467
Copy link
Member

nihal467 commented Mar 23, 2023 •
edited
Loading

@Ashesh3
image

  • unable to create a new asset
  • the location heading is missing

@Ashesh3
Copy link
Member Author

Ashesh3 commented Mar 23, 2023

@Ashesh3 image

  • unable to create a new asset
  • the location heading is missing

Should be fixed now.

@sonarcloud
Copy link

sonarcloud bot commented Mar 23, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 1 Code Smell

No Coverage information No Coverage information
2.0% 2.0% Duplication

@nihal467
Copy link
Member

LGTM

@khavinshankar khavinshankar merged commit 629dd6e into ohcnetwork:develop Mar 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@khavinshankar khavinshankar khavinshankar approved these changes

@mathew-alex mathew-alex Awaiting requested review from mathew-alex

Assignees
No one assigned
Labels
P1 breaking issue or vital feature tested
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Location dropdown: asset creation- MALFUNCTIONING
3 participants
@Ashesh3 @nihal467 @khavinshankar