Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for freeflow text in Referred To Facility #5157

Merged
merged 4 commits into from
Apr 6, 2023
Merged

Add support for freeflow text in Referred To Facility #5157

merged 4 commits into from
Apr 6, 2023

Conversation

Ashesh3
Copy link
Member

@Ashesh3 Ashesh3 commented Mar 23, 2023

Fixes #4876
Backend PR: ohcnetwork/care#1228

@coronasafe/care-fe-code-reviewers @coronasafe/code-reviewers

@Ashesh3 Ashesh3 requested a review from a team March 23, 2023 11:06
@Ashesh3 Ashesh3 requested a review from a team as a code owner March 23, 2023 11:06
@vercel
Copy link

vercel bot commented Mar 23, 2023 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
care-storybook ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 6, 2023 10:57am

@netlify
Copy link

netlify bot commented Mar 23, 2023 •
edited
Loading

✅ Deploy Preview for care-egov-staging ready!

Name Link
🔨 Latest commit 7f972f1
🔍 Latest deploy log https://app.netlify.com/sites/care-egov-staging/deploys/642ea522180ad400088f4872
😎 Deploy Preview https://deploy-preview-5157--care-egov-staging.netlify.app/
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@github-actions github-actions bot added the merge conflict pull requests with merge conflict label Mar 27, 2023
@github-actions
Copy link

👋 Hi, @Ashesh3,
Conflicts have been detected against the base branch. Please rebase your branch against the base branch.

This message is automatically generated by prince-chrismc/label-merge-conflicts-action so don't hesitate to report issues/improvements there.

@nihal467 nihal467 added urgent P1 breaking issue or vital feature and removed waiting for backend labels Apr 6, 2023
@nihal467
Copy link
Member

nihal467 commented Apr 6, 2023

@Ashesh3 the backend is merged , clear the merge conflict and prep it for testing

@Ashesh3 Ashesh3 added needs testing and removed merge conflict pull requests with merge conflict labels Apr 6, 2023
@nihal467
Copy link
Member

nihal467 commented Apr 6, 2023

@Ashesh3
image

  • The droplist has unwanted spacing between the list and text field

image

  • the IP field and referred to another facility text fields are close, can you add spacing in between the fields

@Ashesh3
Copy link
Member Author

Ashesh3 commented Apr 6, 2023

@nihal467 fixed the issues.

image

image

@sonarcloud
Copy link

sonarcloud bot commented Apr 6, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 1 Code Smell

No Coverage information No Coverage information
1.4% 1.4% Duplication

@nihal467
Copy link
Member

nihal467 commented Apr 6, 2023

LGTM

@khavinshankar khavinshankar merged commit 4ae7df7 into ohcnetwork:develop Apr 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@khavinshankar khavinshankar khavinshankar approved these changes

@vigneshhari vigneshhari Awaiting requested review from vigneshhari

Assignees
No one assigned
Labels
P1 breaking issue or vital feature tested urgent
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Referred to another hospital- capture to which hospital
3 participants
@Ashesh3 @nihal467 @khavinshankar