Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Generalize Filters Slideover #5158

Merged
merged 22 commits into from
Apr 5, 2023
Merged

Generalize Filters Slideover #5158

merged 22 commits into from
Apr 5, 2023

Conversation

rithviknishad
Copy link
Member

@rithviknishad rithviknishad commented Mar 23, 2023 •
edited
Loading

Proposed Changes

Just to make it simple to review:

  • Added a component: FiltersSlideover that wraps Slideover with Advanced filter specific common things.
  • Upgrades all Advanced Filters to use the new FiltersSlideover.

image

@coronasafe/care-fe-code-reviewers @coronasafe/code-reviewers

Merge Checklist

  • Add specs that demonstrate bug / test a new feature.
  • Update product documentation.
  • Ensure that UI text is kept in I18n files.
  • Prep screenshot or demo video for changelog entry, and attach it to issue.
  • Request for Peer Reviews
  • Completion of QA

@vercel
Copy link

vercel bot commented Mar 23, 2023 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
care-storybook ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 5, 2023 4:30am

@netlify
Copy link

netlify bot commented Mar 23, 2023 •
edited
Loading

✅ Deploy Preview for care-egov-staging ready!

Name Link
🔨 Latest commit c7d5f1d
🔍 Latest deploy log https://app.netlify.com/sites/care-egov-staging/deploys/642cf8e64b7a81000884101f
😎 Deploy Preview https://deploy-preview-5158--care-egov-staging.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@rithviknishad rithviknishad added Major Code Change This Tag represent PR, which will be causing major Code change in the platform and removed Major Code Change This Tag represent PR, which will be causing major Code change in the platform labels Mar 23, 2023
@rithviknishad rithviknishad marked this pull request as ready for review March 23, 2023 13:36
@rithviknishad rithviknishad requested a review from a team March 23, 2023 13:36
@rithviknishad rithviknishad requested a review from a team as a code owner March 23, 2023 13:36
@github-actions github-actions bot added the cypress failed pull request with cypress test failure label Mar 23, 2023
@shivankacker
Copy link
Member

@rithviknishad some filters have base dropdowns and inputs rather than CAREUI. Is that out of the scope of this PR?

@github-actions github-actions bot added the cypress failed pull request with cypress test failure label Mar 29, 2023
@nihal467
Copy link
Member

nihal467 commented Apr 3, 2023

@rithviknishad
image

LGTM, but in the asset page, the applied filter of the location, is not showing, the slide-over, can you check it ASAP

@rithviknishad rithviknishad added needs testing and removed test failed cypress failed pull request with cypress test failure labels Apr 3, 2023
@nihal467
Copy link
Member

nihal467 commented Apr 3, 2023

LGTM

@github-actions github-actions bot added cypress failed pull request with cypress test failure merge conflict pull requests with merge conflict labels Apr 3, 2023
@github-actions
Copy link

github-actions bot commented Apr 5, 2023

👋 Hi, @rithviknishad,
Conflicts have been detected against the base branch. Please rebase your branch against the base branch.

This message is automatically generated by prince-chrismc/label-merge-conflicts-action so don't hesitate to report issues/improvements there.

@khavinshankar
Copy link
Member

@rithviknishad can you clear out merge conflicts

@rithviknishad rithviknishad removed the merge conflict pull requests with merge conflict label Apr 5, 2023
@rithviknishad
Copy link
Member Author

@khavinshankar done

@sonarcloud
Copy link

sonarcloud bot commented Apr 5, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 5 Code Smells

No Coverage information No Coverage information
2.5% 2.5% Duplication

@khavinshankar khavinshankar merged commit d56dfc0 into develop Apr 5, 2023
@github-actions
Copy link

github-actions bot commented Apr 5, 2023

@rithviknishad We truly appreciate your efforts. Thank you for taking the time to contribute; this is a very valuable contribution to us 🥇. We always welcome your contribution 🙂, so feel free to contribute to anything anytime, and never lose that spirit of innovation 🙌.

@rithviknishad rithviknishad deleted the tailwind/FiltersSlideover branch July 26, 2023 13:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@khavinshankar khavinshankar khavinshankar approved these changes

@shivankacker shivankacker shivankacker approved these changes

@bodhish bodhish Awaiting requested review from bodhish

Assignees
No one assigned
Labels
cypress failed pull request with cypress test failure redesign tested
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Localizations for texts in Facility/FacilityFilter Redesign and generalization for SlideOver components.
4 participants
@rithviknishad @shivankacker @nihal467 @khavinshankar