Show all available skills when adding a skill to user #5167
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
✅ Deploy Preview for care-egov-staging ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
|
Kudos, SonarCloud Quality Gate passed!
|
Pranshu1902
approved these changes
Mar 26, 2023
|
LGTM |
khavinshankar
approved these changes
Mar 28, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes #5153
This PR updates the SkillsSlideOver component to show all available options when adding a skill instead of limiting it to 8. The showNOptions prop has been updated to Infinity to allow for an unlimited number of options to be displayed.
Motivation
Previously, the SkillsSlideOver component only displayed up to 8 options when adding a skill. This limited the user's ability to easily find and select the desired skill. By updating the component to show all available options, we improve the user experience and make it easier for users to add the skills they need.
Testing
Manual testing was performed to ensure that all available options were displayed in the SkillsSlideOver component when adding a skill.
Screenshots
@coronasafe/care-fe-code-reviewers @coronasafe/code-reviewers