Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve support for toll free numbers #5330

Merged
merged 6 commits into from
May 9, 2023

Conversation

Ashesh3
Copy link
Member

@Ashesh3 Ashesh3 commented Apr 12, 2023

Description

🤖 Generated by Copilot at be68da2

This pull request enhances the phone number input fields in various components of the frontend application. It uses the LegacyPhoneNumberField component to handle different phone number formats and validations, and improves the user interface and experience for the users. It affects the files HelperInputFields.tsx and AssetCreate.tsx.

Proposed Changes

- When tollfree support is enabled

image

image
image

image
image

- When tollfree support is disabled

(Nothing changes for this case)
image

@coronasafe/care-fe-code-reviewers @coronasafe/code-reviewers

Poem

🤖 Generated by Copilot at be68da2

Oh we're the coders of the LegacyPhoneNumberField
We make it work for toll-free and regular
We heave and ho and update the UI
And validate the support_phone with a sigh

Walkthrough

🤖 Generated by Copilot at be68da2

  • Modify the LegacyPhoneNumberField component to accept toll-free and regular phone numbers with different validation and formatting logic (link, link, link)
  • Modify the AssetCreate component to validate and format the support_phone field based on the toll-free or regular number type (link, link)

@Ashesh3 Ashesh3 added needs testing P1 breaking issue or vital feature labels Apr 12, 2023
@Ashesh3 Ashesh3 requested a review from a team April 12, 2023 18:54
@Ashesh3 Ashesh3 requested a review from a team as a code owner April 12, 2023 18:54
@vercel
Copy link

vercel bot commented Apr 12, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
care-storybook ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 8, 2023 7:18am

@netlify
Copy link

netlify bot commented Apr 12, 2023

Deploy Preview for care-egov-staging ready!

Name Link
🔨 Latest commit 5408475
🔍 Latest deploy log https://app.netlify.com/sites/care-egov-staging/deploys/6458a214b81064000872424d
😎 Deploy Preview https://deploy-preview-5330--care-egov-staging.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@nihal467
Copy link
Member

nihal467 commented Apr 13, 2023

@sonarcloud
Copy link

sonarcloud bot commented May 8, 2023

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot E 1 Security Hotspot
Code Smell A 1 Code Smell

No Coverage information No Coverage information
1.7% 1.7% Duplication

@nihal467
Copy link
Member

nihal467 commented May 8, 2023

LGTM

@nihal467 nihal467 added the tested label May 8, 2023
@khavinshankar khavinshankar merged commit c632858 into ohcnetwork:develop May 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
P1 breaking issue or vital feature tested
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Asset registration- Support tollfree No.
3 participants