-
Notifications
You must be signed in to change notification settings - Fork 437
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve support for toll free numbers #5330
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
✅ Deploy Preview for care-egov-staging ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
unable to update customer support number |
SonarCloud Quality Gate failed. 0 Bugs No Coverage information |
LGTM |
khavinshankar
approved these changes
May 9, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
🤖 Generated by Copilot at be68da2
This pull request enhances the phone number input fields in various components of the frontend application. It uses the
LegacyPhoneNumberField
component to handle different phone number formats and validations, and improves the user interface and experience for the users. It affects the filesHelperInputFields.tsx
andAssetCreate.tsx
.Proposed Changes
- When
tollfree
support is enabled- When
tollfree
support is disabled(Nothing changes for this case)
@coronasafe/care-fe-code-reviewers @coronasafe/code-reviewers
Poem
🤖 Generated by Copilot at be68da2
Walkthrough
🤖 Generated by Copilot at be68da2
LegacyPhoneNumberField
component to accept toll-free and regular phone numbers with different validation and formatting logic (link, link, link)AssetCreate
component to validate and format thesupport_phone
field based on the toll-free or regular number type (link, link)