Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

made the assigned to field only available to wartime mode #5411

Merged
merged 5 commits into from
Apr 26, 2023

Conversation

patelaryan7751
Copy link
Contributor

@patelaryan7751 patelaryan7751 commented Apr 25, 2023

WHAT

🤖 Generated by Copilot at 5574e07

Enhance ShiftDetailsUpdate component for wartime shifting mode. Add type annotations, conditional rendering, and UI adjustments to improve code quality, business logic, and UI design.

Proposed Changes

@coronasafe/care-fe-code-reviewers @coronasafe/code-reviewers

Merge Checklist

  • Add specs that demonstrate bug / test a new feature.
  • Update product documentation.
  • Ensure that UI text is kept in I18n files.
  • Prep screenshot or demo video for changelog entry, and attach it to issue.
  • Request for Peer Reviews
  • Completion of QA

HOW

🤖 Generated by Copilot at 5574e07

  • Import FieldChangeEvent type and use it to annotate handleChange parameter in ShiftDetailsUpdate component (link)
  • Render assigned_to field and UserSelect component only if wartime_shifting is true, and adjust className prop of SelectField component accordingly in ShiftDetailsUpdate component (link)
  • Add conditional className prop to div element that wraps remarks field to improve UI spacing and alignment in ShiftDetailsUpdate component (link)

@patelaryan7751 patelaryan7751 added needs testing P1 breaking issue or vital feature shifting labels Apr 25, 2023
@patelaryan7751 patelaryan7751 requested a review from a team April 25, 2023 19:08
@patelaryan7751 patelaryan7751 requested a review from a team as a code owner April 25, 2023 19:08
@vercel
Copy link

vercel bot commented Apr 25, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
care-storybook ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 26, 2023 1:50pm

@netlify
Copy link

netlify bot commented Apr 25, 2023

Deploy Preview for care-egov-staging ready!

Name Link
🔨 Latest commit 387e593
🔍 Latest deploy log https://app.netlify.com/sites/care-egov-staging/deploys/64492bff37085500087be351
😎 Deploy Preview https://deploy-preview-5411--care-egov-staging.netlify.app/
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

Copy link
Member

@khavinshankar khavinshankar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@patelaryan7751 some minor changes, can you please fix it asap

src/Components/Shifting/ShiftDetailsUpdate.tsx Outdated Show resolved Hide resolved
src/Components/Shifting/ShiftDetailsUpdate.tsx Outdated Show resolved Hide resolved
@sonarcloud
Copy link

sonarcloud bot commented Apr 26, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@nihal467
Copy link
Member

LGTM

@khavinshankar khavinshankar merged commit 3790a48 into ohcnetwork:develop Apr 26, 2023
@rithviknishad rithviknishad added this to the Shifting Module milestone Aug 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
P1 breaking issue or vital feature tested urgent
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update shift request- assign to-wartime
4 participants